search

dropbox / pb-jelly

A protobuf code generation framework for the Rust language developed at Dropbox.
Apache License 2.0
610 stars 25 forks source link

add edition to rust_library #57

Closed RSMuthu closed 3 years ago

RSMuthu commented 3 years ago

Hi, Please review it and merge the branch. This my first contribution try. Please let me know if i have missed out any

RSMuthu commented 3 years ago

I ran cargo for testing ... But getting the following error ..

   Compiling glob v0.3.0
error: linker `link.exe` not found
  |
  = note: The system cannot find the file specified. (os error 2)

Can you please tell what I am missing ?

nipunn1313 commented 3 years ago

Hi,

Haven't tested it out on windows - though I suspect it should work just fine. Googling your error message, I suspect it's a toolchain issue (eg https://stackoverflow.com/questions/55603111/unable-to-compile-rust-hello-world-on-windows-linker-link-exe-not-found)

Thanks for the PR! Looks good!

nipunn1313 commented 3 years ago

Don't mind the CI failure - I'm still working on getting that up and running!

nipunn1313 commented 3 years ago

I credited you in the README! Thank you for the contribution. If I may ask, would you be able to fill out the CLA agreement? Thanks https://opensource.dropbox.com/cla/

RSMuthu commented 3 years ago

Thanks. Yes Sure, I have filled it out just now