dropbox / pyannotate

Auto-generate PEP-484 annotations
Apache License 2.0
1.43k stars 59 forks source link

Some things we can learn from pytypes #38

Open gvanrossum opened 6 years ago

gvanrossum commented 6 years ago

I checked the profiling hook in pytypes, and they do two things we should also do:

gvanrossum commented 6 years ago

Moreover if a previous profiler is already running they pass events to that too!

gvanrossum commented 6 years ago

Lots of other stuff too, e.g. their utilities for finding the actual function. (OTOH I don't see any downsampling or other speed hacks in their code.)

Stewori commented 6 years ago

Yes, the downsampling idea is something we can learn from pyannotate. I will surely add this.