Python3 annotations - Githubissues

dropbox / pyannotate

Auto-generate PEP-484 annotations

Apache License 2.0

1.43k stars 59 forks source link

Python3 annotations #74

Closed bluebird75 closed 6 years ago

bluebird75 commented 6 years ago

Implementation for #4 is done.

All tests are ported and pass successfully.

A few remarks on the implementation :

command-line options are the same as mypy : -2, --py2, -3, --py3, --python-version
the code will not annotate functions with an existing py2 or py3 annotation
I ignored the concept of long form for python 3 annotations. Function with many arguments are still annotated inline.
test_annotate.py and test_annotate_json.py have been renamed with a _py2 and _py3 suffix depending on what they are testing.

Looking forward for your feedback.

gvanrossum commented 6 years ago

Thanks! Reviewing this will take a bit of time, but your work is very much appreciated already!

bluebird75 commented 6 years ago

Sure. I'll be patient then...

gvanrossum commented 6 years ago

@bluebird75 I realize I took my time reviewing this. I am going on vacation for the next 3 weeks so unless I get terribly bored at my holiday destination I won't be reviewing your next commit very soon. Sorry! It's good work, it just needs one more round.

bluebird75 commented 6 years ago

So, to sum-up, a few PEP8 issues and better use of argparse. That's not too bad. I was never very PEP8 friendly so that's not so surprising. :-) I'll work on all that in the coming weeks and provide an update.

You probably don't know but we've met before: I interviewed you at FOSDEM 2002 in Brussel when you came to receive the FSF award: http://www.freehackers.org/Fosdem_2002:_Guido_van_Rossum_interview . I can't believe it's been 16 years !

bluebird75 commented 6 years ago

Here is a new version. Note that the CI failure is not due to the changes here but to some changes at Travis CI. See https://github.com/dropbox/pyannotate/pull/76 for fixing them.

gvanrossum commented 6 years ago

And there was great rejoicing!

gvanrossum commented 6 years ago

Seriously, thanks for hanging in there and shaving some yaks. We should celebrate by doing a point release!

bluebird75 commented 6 years ago

I'll be more than happy to celebrate with a release. I'll see where I can contribute next. Multi-source type annotations looks like a big topic to me.

laike9m commented 5 years ago

Do we have a release plan for this?

gvanrossum commented 5 years ago

It's released now: https://pypi.org/project/pyannotate/1.0.7/