Events module

[khardsonhurley]

@gmjosack in this diff you will see the following changes:

Format Changes

• Copied the contents of __init__.py into v2.py to allow for second version of the library.
• Moved event methods into its own module and updated imports.

V1-> V2 Changes

• Changed the base path to: https://api.pagerduty.com/. (line 538)
• Added version in the request header. (line 22)
• Removed max number of 403 errors, since in v2 rate limited requests will now return a 429 Too many requests error code instead of 403 Forbidden. They no longer want us to retry a request that returns 403. (line 572)

Changes to come

• Updating tests to reflect new structure -- do you have advice on how to do this as to not disrupt the tests for v1? Perhaps a new directory v2_tests/?
• Removing requester_id and moving this to the header of the request.

[khardsonhurley]

Do you know why those Travis checks are failing? I tried to run the tests on my machine and also had issues (for example when I tried to run user_test.py I got an import error, even after running python setup.py install). Am I missing something @gmjosack ?

[gmjosack]

Take a look at https://travis-ci.org/dropbox/pygerduty/jobs/236195360#L170

It's failing because flake8 has errors/warnings

[gmjosack]

The requester.execute_request is still tightly reliant on the Pagerduty class. Ideally the methods in the events module would not need to live on a class at all, let alone inherit from the Pagerduty class which is specific to the REST api. You should be able to pull the opener stuff to live with the request code and pull out the json logic into its own abstraction.

[khardsonhurley]

When you recommended pulling the opener stuff, were you referencing this:

try:
        response = (pagerduty.opener.open(request, timeout=pagerduty.timeout).read().decode("utf-8"))

from the execute_request method? Are you suggesting to move it into the Pagerduty class when you say You should be able to pull the opener stuff to live with the request code?

[khardsonhurley]

Travis is complaining about this:

pygerduty/v2.py:522:17: E128 continuation line under-indented for visual indent

But I believe this was something from the original __init__.py file, would you prefer that I leave it or change to quiet the failure?

[gmjosack]

You just need to add a space on line 522 to align proxies with self. Looks like that changed when you updated the attributes passed to init.