dropbox / pygerduty

A Python library for PagerDuty.
MIT License
163 stars 72 forks source link

Changes to relieve bugs found during testing #58

Closed khardsonhurley closed 7 years ago

khardsonhurley commented 7 years ago
gmjosack commented 7 years ago

Is the Entries class still used or can it be removed now?

khardsonhurley commented 7 years ago

From what I can tell only LogEntries class will be used now (https://v2.developer.pagerduty.com/v2/page/api-reference#!/Log_Entries/get_log_entries). I will go ahead and remove.

khardsonhurley commented 7 years ago

Actually, was entries meant to encapsulate the rendered_schedule_entries when you wrote the library? This has not since been removed:

https://v2.developer.pagerduty.com/v2/page/api-reference#!/Schedules/get_schedules_id https://v1.developer.pagerduty.com/documentation/rest/schedules/show screenshot 2017-07-10 16 46 22

gmjosack commented 7 years ago

Pretty sure it was specifically for entries returned by the api that was removed.