dropbox / pynsot

A Python client and CLI utility for the Network Source of Truth (NSoT) REST API.
https://pynsot.readthedocs.io
Other
46 stars 25 forks source link

Fix tests that are broken with the latest version of NSoT #126

Closed nickpegg closed 7 years ago

nickpegg commented 7 years ago

The cases of incorrect networks were modified based on my interpretation of the test code. Please let me know if I'm wrong and they truly should be the old values.

nickpegg commented 7 years ago

So tests weren't actually directly broken in master, they just started failing for me locally because I had upgraded NSoT to latest on my local machine (long story short, cryptography doesn't build with latest libssl). We definitely should be testing against latest NSoT though, so these should definitely be fixed.

From digging into the root causes here to make sure this PR is justified:

Overall I feel confident that the way I fixed these tests is the correct way