Enhanced support for viewing/updating objects by "natural key". - Githubissues

dropbox / pynsot

A Python client and CLI utility for the Network Source of Truth (NSoT) REST API.

https://pynsot.readthedocs.io

Other

46 stars 25 forks source link

Enhanced support for viewing/updating objects by "natural key". #71

Closed jathanism closed 8 years ago

jathanism commented 8 years ago

Fixes #66

Detailed changes:

App

pynsot.commands.callbacks.list_endpoint() renamed to list_subcommand()
pynsot.commands.callbacks.get_resource_by_natural_key() factored out for eas of use by list_subcommand()
A bunch of variables renamed for readability
pysnot.app.list() expanded to try lookup by id first, then natural_key, then params.
pysnot.app.get_single_object() enhanced to support natural_key lookups for all resources.

Attributes

lookup by name, resource_name will display verbosely
'id' added to verbose display

Devices

Lookup by hostname will display verbosely
You may now update a device by providing -H/--hostname
-i/--id is no longer required, unless you wish to update the hostname for the device.

Networks

lookup by cidr will display verbosely
-c/--cidr added to update for lookup only
You may now update a device by providing -c/--cidr
-i/--id is no longer required unless -c/--cidr is not provided

Interfaces

lookup by name, device will display verbosely
'id' added to verbose display
No changes yet made or tested for updating interfaces

Unit Tests

All hard-coded output tests replaced with content matching. It's just too tedious to test the output so explicitly.