search

dropbox / rust-brotli

Brotli compressor and decompressor written in rust that optionally avoids the stdlib
https://dropbox.tech/infrastructure/-broccoli--syncing-faster-by-syncing-less
BSD 3-Clause "New" or "Revised" License
797 stars 83 forks source link

Use proper `self` instead of `xself` #165

Closed nyurik closed 3 months ago

nyurik commented 3 months ago

There are a lot of hacky xself that should use self. This PR currently has only one minor change, but I would like to change all/most of them in the similar manner. Note that the usage here is a bit strange - a struct is created only to be discarded right after.

Note that since this is a breaking change, we should also rename the methods to conform to Rust naming standards... although I am not sure these should even be public - seems like an implementation detail that should be hidden

Are there any reasons to preserve xself?

nyurik commented 3 months ago

Replaced by #175