Add typing to ORM query return value

dropbox / sqlalchemy-stubs

Mypy plugin and stubs for SQLAlchemy

Apache License 2.0

573 stars 101 forks source link

Add typing to ORM query return value #121

Closed qsantos closed 1 year ago

qsantos commented 5 years ago

This obviously does not cover every case, but it is a significant improvement in that it enables typing on the results of most queries.

ilevkivskyi commented 5 years ago

Also please note tests are failing (you should probably add an explicit __iter__ override).

qsantos commented 5 years ago

[x] CLA signed
[ ] __iter__ was making something fail during typecheck; I'll see if I can fix it
[ ] I'll run the tests of the CI locally to fix the issues with linting/automated testing
[x] other issues you raised fixed

Nice CI by the way!

ilevkivskyi commented 5 years ago

Thanks for updates! All looks good now, I am just waiting for the test fix.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}