search

dropbox / sqlalchemy-stubs

Mypy plugin and stubs for SQLAlchemy
Apache License 2.0
570 stars 101 forks source link

Fixes/is operator and jsonb #211

Closed Pavkazzz closed 3 years ago

Pavkazzz commented 3 years ago

Fix: https://github.com/dropbox/sqlalchemy-stubs/issues/207

moui72 commented 3 years ago

please merge! :D

jhirshman commented 3 years ago

I have a PR up that does something similar: https://github.com/dropbox/sqlalchemy-stubs/pull/211

It hasn't been merged in a while.

Pavkazzz commented 3 years ago

@jhirshman i suppose you mean #202. Maybe we should fork and upload it to pypi, while dropbox doesn't maintain this package?

jhirshman commented 3 years ago

@jhirshman i suppose you mean #202. Maybe we should fork and upload it to pypi, while dropbox doesn't maintain this package?

yes, sorry. I linked to the wrong one.

I agree that forking it might be the right solution here.

peterschutt commented 3 years ago

If you haven’t already seen, check out the more recent activity on this issue and this issue.

It seems as though we are fortunate enough that Mike has turned his attention to having typing integration with sqla 1.4/2.0.

I mention this as it might change your opinion as to the need to fork the repo.