search

dropbox / sqlalchemy-stubs

Mypy plugin and stubs for SQLAlchemy
Apache License 2.0
570 stars 101 forks source link

Fix sqlalchemy.ddl.DDL.execute_if dialect type (#181) #219

Open philpep opened 3 years ago

philpep commented 3 years ago

dialect should be a string a list/tuple/set of strings. Not a Dialect object.

https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_4_18/lib/sqlalchemy/sql/ddl.py#L158

Closes #181

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

jace commented 2 years ago

Wow, this has been stuck a while.