dropbox / sqlalchemy-stubs

Mypy plugin and stubs for SQLAlchemy
Apache License 2.0
572 stars 102 forks source link

declarative_base available from sqlalchemy.orm in 1.4 #250

Open philbudne opened 2 years ago

philbudne commented 2 years ago

https://docs.sqlalchemy.org/en/14/orm/extensions/declarative/

Changed in version 1.4: The vast majority of the Declarative extension is now integrated into the SQLAlchemy ORM and is importable from the sqlalchemy.orm namespace.

Using the old location (ext.declarative) gives a deprecation warning when SQLALCHEMY_WARN_20 enabled.

Evan6998 commented 2 years ago

same, can not use from sqlalchemy.orm import declarative_base now, which throws error: Invalid base class "Base" [misc]

astrojuanlu commented 1 year ago

The last update of sqlalchemy.orm.__init__.pyi was 2 years ago, before SQLAlchemy 1.4.0 was released. Wondering if the authors would consider merging a pull request with a fix, although there seem to be a bunch of unanswered PRs.

slifty commented 4 months ago

Following up here since I'm facing this for the as_declarative -- I get a deprecation warning, but when It ry to import from sqlalchemy.orm the type check fails.