search

dropbox / zxcvbn

Low-Budget Password Strength Estimation
https://www.usenix.org/conference/usenixsecurity16/technical-sessions/presentation/wheeler
MIT License
14.98k stars 931 forks source link

Position of \| on the qwerty US keyboard in the data script ? #275

Open adorbabble opened 4 years ago

adorbabble commented 4 years ago

Hi, in the script build_keyboard_adjacency_graphs.py, \| was put at the end of the second line of the qwerty keyboard ; however, this key is actually at the bottom left of such a keyboard… Why was it done this way ?? And we can’t just change its location to the bottom left without also changing the code since it uses a shift of 1 position for every new line (slant = y - 1 if slanted), so this doesn’t work because the last line starts further to the left than the second-to-last line.

dopeghoti commented 4 years ago

On most en-US keyboards with a QWERTY layout, the end of the second row is OP[]\; the lower leftmost key is typically a Control key.

adorbabble commented 4 years ago

On most en-US keyboards with a QWERTY layout, the end of the second row is OP[]\; the lower leftmost key is typically a Control key.

Oh… you’re right, I hadn’t realised that, I’m sorry ! So, that’s another internationalisation issue with this library, because QWERTZ and AZERTY European keyboards have a different physical layout, with a larger Enter key and a key in the lower left corner between Shift and the Y/Z key