search

dropbox / zxcvbn

Low-Budget Password Strength Estimation
https://www.usenix.org/conference/usenixsecurity16/technical-sessions/presentation/wheeler
MIT License
15.06k stars 937 forks source link

uk keyboard layout #45

Open insacuri opened 10 years ago

insacuri commented 10 years ago

Possible feature that could be added is having a uk and us keyboard layout in the adjacency graph. At the moment doing !"£$%^&*() gets a score greater than 1 which is probably wrong because its a fairly simple sequence.

I forked it and tried to implement it myself but the graph generation script doesn't play nice with the £ sign because its a unicode character and all the other characters are ASCII (i.e., when doing len(3£) it returns 3 instead of 2 because the £ is considered by bytes.

Another workaround for this could just be to add !"£$%^&*() to one of the dictionaries of penalised words.

lowe commented 9 years ago

Support for more keyboard layouts is on the roadmap, thanks for suggesting. I'll keep this open until uk keyboard layouts work as you expect.