Fix docker image generation in Dockerfile - Githubissues

droppyjs / droppy

Self-hosted file storage

https://droppyjs.com

BSD 2-Clause "Simplified" License

107 stars 13 forks source link

Fix docker image generation in Dockerfile #5

Closed gissehel closed 3 years ago

gissehel commented 3 years ago

Closes: #4

What are the changes and their implications?

There is a new Dockerfile
docker-start.sh has been modified to reflect the changes
The Dockerfile doesn't use working copy, but use source from https://github.com/droppy-js/droppy
The Makefile is able to generate Dockerfile-dev which works like Dockerfile but for working copy

The resulting image has been tested with parametrized UID and GID, and it works as expected.

Checklist

[ ] Changes covered by tests (tests added if needed)
[ ] PR submitted to droppy-js.com for any user facing changes

markhughes commented 3 years ago

Thanks for adjusting that! Appreciate the help!