search

droptica / droopler

https://www.droopler.com
GNU General Public License v2.0
60 stars 20 forks source link

4.0 Branch Install Step 2 fails #896

Closed 35develr closed 9 months ago

35develr commented 9 months ago

Got error 'PHP message: PHP Fatal error: Declaration of Drupal\d_frontend_editing\Controller\FrontendEditingController::paragraphAddPage($parent_type, $parent, $parent_field_name, $current_paragraph, $before): array must be compatible with Drupal\frontend_editing\Controller\FrontendEditingController::paragraphAddPage($parent_type, $parent, $parent_field_name, $current_paragraph, $before, Symfony\Component\HttpFoundation\Request $request) in /mnt/HC_Volume_100239027/www/html/tinyhouse/web/profiles/contrib/droopler/modules/custom/d_frontend_editing/src/Controller/FrontendEditingController.php on line 19', referer: https://XXXXXXXXX/core/install.php?rewrite=ok&profile=droopler&langcode=de&id=1&op=start

35develr commented 9 months ago

Solution:

Add $request to function paragraphAddPage in /web/profiles/contrib/droopler/modules/custom/d_frontend_editing/src/Controller/FrontendEditingController.php on line 19


  public function paragraphAddPage($parent_type, $parent, $parent_field_name, $current_paragraph, $before, $request): array {
    $build = parent::paragraphAddPage($parent_type, $parent, $parent_field_name, $current_paragraph, $before,  $request);
js-droptica commented 9 months ago

Hi. Yes, we already updated the code. We will try to release alpha2 today with this and a few other updates.

js-droptica commented 9 months ago

The new 4.0.0-alpha2 has been released. It contains the fox for this issue.

Thanks and all the best :)