Unit Of Work Support For JDBI

dropwizard / dropwizard-jdbi

Dropwizard JDBI v2 support

Apache License 2.0

1 stars 7 forks source link

Unit Of Work Support For JDBI #14

Open isopropylcyanide opened 4 years ago

isopropylcyanide commented 4 years ago

I've published a package to Maven Central that I've developed to add Support for Unit of Work for a Dropwizard App that uses JDBI using a @JdbiUnitOfWork annotation

The project lives here: https://github.com/isopropylcyanide/dropwizard-jdbi-unitofwork

I'm interested in contributing upstream. Would really appreciate if someone can review the source and see if it's worth it. It is being actively used in our production since the last quarter. I have also published a series of articles on the same

Part I Part II

joschi commented 4 years ago

@isopropylcyanide Thanks for opening this issue and for your write-up! Sorry it took a bit longer to respond.

I see that your project is aimed ad jDBI 2.x (via dropwizard-jdbi) and not Jdbi 3 (via dropwizard-jdbi3).

Since we split out the jDBI 2.x support in Dropwizard 2.0.0, it would make sense to create a pull request against https://github.com/dropwizard/dropwizard-jdbi/.

What do you think?

isopropylcyanide commented 4 years ago

I agree. I'll raise it over there. Thank you.

joschi commented 4 years ago

@isopropylcyanide I've transferred the issue to the other repository.

isopropylcyanide commented 3 years ago

@joschi I think the issue was transferred here. Can we resurrect this thread?

Does it make sense if I work towards migrating this to JDBI v3. Do you see a value in this project?

joschi commented 3 years ago

Does it make sense if I work towards migrating this to JDBI v3. Do you see a value in this project?

There still seem to be some projects using jDBI 2.x with Dropwizard 2.x:

Maven Central statistics for dropwizard-jdbi

So merging https://github.com/isopropylcyanide/dropwizard-jdbi-unitofwork into this project would definitely not be wasted effort.

On a personal note, it would be great to get both, support for jDBI 2.x in this project and getting support for JDBI 3.x in https://github.com/dropwizard/dropwizard/.

Feel free to open a PR here for merging the upstream project and I'll be happy to review & merge. 😃

isopropylcyanide commented 3 years ago

I'll work on both. Need to test changes for 3.x though. Thanks for the visualization on the usages of 2.0. Pretty cool.