drostlab / myTAI

Evolutionary Transcriptomics with R
https://drostlab.github.io/myTAI/
GNU General Public License v2.0
38 stars 16 forks source link

improved fit, added ks-test #17

Closed lavakin closed 1 year ago

lavakin commented 1 year ago

Removing outliers and selecting the best fit. Added ks-test (computed on the filtered data) to the output statistics.

HajkD commented 1 year ago

Hi @lavakin

Thank you so much for pushing this forward!

Everything looks great and ready to me!

Just two little edits:

1) Would it be possible to use message() instead of print() in all cases. 2) Since vector/array indexing in R starts with 1, would it be possible to double check that 0 indexing doesn't cause any unwanted/unforeseen issues?

With many thanks, Hajk

lavakin commented 1 year ago

Done :)

HajkD commented 1 year ago

Brilliant! Thank you so much :)

LotharukpongJS commented 1 year ago

Hi @HajkD and @lavakin ,

Nice additions! In terms of testing the new functionalities, have you run devtools::check()?

Best, Sodai