search

drostlab / myTAI

Evolutionary Transcriptomics with R
https://drostlab.github.io/myTAI/
GNU General Public License v2.0
39 stars 16 forks source link

Huge variance issue fixed #37

Closed lavakin closed 1 year ago

lavakin commented 1 year ago

Fixed the huge variance issue, shown by the PlotSignatures() plots. At the end, the problem wasn't in adding the permutations into one common matrix. That indeed is handled well by the cpp libraries. The problem was sharing the phylostrata vector between threads (even though it was copies by value not reference).

It also improved the gamma fit very significantly, so at the end, I would suggest to use the gamma p-value.

HajkD commented 1 year ago

Dear @lavakin

Thank you very much for looking into this and for solving the large-sd issue!

I can confirm that this solves it initial issue.

With many thanks and very best wishes, Hjak