Add CMake rule to ensure LPCNet is built with the correct OSX libraries.

drowe67 / LPCNet

Experimental Neural Net speech coding for FreeDV

BSD 3-Clause "New" or "Revised" License

69 stars 24 forks source link

Add CMake rule to ensure LPCNet is built with the correct OSX libraries. #14

Closed tmiw closed 4 years ago

tmiw commented 4 years ago

Looks like the latest OSX SDK adds a ____chkstk_darwin symbol reference libraries/executables built for 10.14 and later. This results in crashes on older OSX releases when using a binary built on a newer version (example).

Anyway, forcing CMAKE_OSX_DEPLOYMENT_TARGET like what's done on FreeDV resolves the issue.

tmiw commented 4 years ago

@drowe67, updates on this? Looks like someone reported on IRC that the OSX version of FreeDV that they tried to build crashes when using 2020 mode. (My prebuilt dmg should already have this PR in it, so anyone using that should be okay.)

drowe67 commented 4 years ago

@tmiw Oh dear I missed this PR completely - sorry about that! Sometimes I don't get the emails from GitHub - pls feel free to ping me if I don't respond in a few days ...

Thanks for the PR :+1: