search

drowe67 / LPCNet

Experimental Neural Net speech coding for FreeDV
BSD 3-Clause "New" or "Revised" License
68 stars 24 forks source link

Fixes aarch64 builds. #23

Closed hobbes1069 closed 4 years ago

hobbes1069 commented 4 years ago

David, would like your input before merging.

drowe67 commented 4 years ago

@hobbes1069 sorry I missed this until now - just discovered i wasn't "watching" this repo so wasn't being notified of PRs!

Changes look fine with me, and x86 Travis tests pass. Is it possible to actually test if these changes produce working code on the target platform?

Couple of other thoughts:

  1. AFAIK Pi's can't run LPCNet in real time, although it's not an area I have been keeping up with. I've been told it can run on faster ARMs (like in a modern cell phone).
  2. freedv-gui isn't set up for this arch, it only looks for AVX before enabling FreeDV 2020/LPCNet.
hobbes1069 commented 4 years ago
  1. This was my attempt to just get it to "build" which is usually (but not always) a good indication. It's preferable from a Distro POV to have at least good builds even if the host system doesn't have the horsepower to actually run it. Using "ExcludeArch" in packages is only a last resort if you can't actually build for that architecture for some reason. Even my humongus FreeCAD packages get built for armv7hl which I doubt it would run on.
  2. It may not be setup but it's been building for x86_64, i686, armv7hl, aarch64, ppc64le, and s390x ever since I packaged it for Fedora :)