Closed tmiw closed 3 years ago
@drowe67, just realized I should have created this issue in codec2 and not here. Should I recreate there and close this one?
@drowe67, just realized I should have created this issue in codec2 and not here. Should I recreate there and close this one?
Nah it's OK here :+1:
I'll write a ctest at the Codec 2 API level for the 1600 txt feature. I just noticed it's not part of the standard freedv_rx.c
demo any more, so I may have broken the feature and not realised.
@tmiw pls see https://github.com/drowe67/codec2/pull/176 from c5e58d03
Tracking that one down made me realise the protocol/frame format for FreeDV 1600 isn't documented anywhere!
@drowe67, no worries. Just tested the latest changes from the linked PR and 1600's text field works fine now. 👍
During testing of FreeDV 1.5.3 Siegfried Jackstien discovered that no text was being decoded by FreeDV in 1600 mode. On further investigation, it looks like Codec2 properly calls
my_get_next_tx_char()
to transmit the text but the following if block (freedv_1600.c lines 207-210) never callsmy_put_next_rx_char()
:Test procedure:
Expected behavior: Text begins to appear in the text field at the bottom of the main GUI. Actual behavior: Generally no text. Rarely characters appear in the text field at the bottom due to corruption between TX and RX.
Codec2 branch tested: https://github.com/drowe67/codec2/tree/dr-2020-passthrough