search

drowe67 / freedv-gui

GUI Application for FreeDV – open source digital voice for HF radio
https://freedv.org/
GNU Lesser General Public License v2.1
206 stars 52 forks source link

Identity of connected radio missing #253

Closed Tyrbiter closed 2 years ago

Tyrbiter commented 2 years ago

Could freedv-gui please add the identity or model of the connected radio in the main window please.

Hamlib seems to change the list and this is not picked up by freedv so I end up wondering why the radio gets multiple selections, changing VFOs and similar because of the mismatch of the PTT setup with the real radio.

As an example if Kenwood TS-890S is selected then I would hope to see just TS-890S in the corner of the window.

tmiw commented 2 years ago

I'm wondering if a more appropriate solution would be to match the device based on the name and not the index in the list that hamlib generates (similar to what's done for audio devices). That way, unless hamlib removes a radio (do they ever do that, BTW?) the configuration shouldn't change on its own.

Also, how often does hamlib update the radio list? I didn't think that happened often for most distros but maybe bleeding edge releases update a lot more often.

Tyrbiter commented 2 years ago

I don't mind how this match is achieved, it's just that recently hamlib changes upset this without an obvious notification. I spent several days with FreeDV-GUI talking to a TS-870S instead of a TS-890 (it's an off-by-one error) it was a silent change. Unlike previous cases this worked, but it was sending enough settings in sequence that I realised something was wrong after listening to multiple relays switching on each FreeDV startup.

I've seen quite a few changes in the Hamlib radio list, maybe 3 or 4 instances of this sort of problem in the last year. .For some reason this manifests as the same off by one error and FreeDV shows TS-870S in the PTT configuration tab. In the past there have been massive changes in the rig model numbering in hamlib, and no guarantee it won't happen when hamlib-5 appears.

I raised this issue as I thought having an indication of what FreeDV thinks it's controlling would be useful. If you can work around the issue that caused it then I accept it's not essential.

tmiw commented 2 years ago

Give PR #256 a shot? It might be a while before we're 100% sure it solves your problem but we can at least see if there's any obvious major issues.

Tyrbiter commented 2 years ago

OK, I have rebuilt and installed this and will keep an eye on things. Hamlib has had a lot of changes and will continue to do so, that should give this a good test over the next few months.

Thanks for your assistance @tmiw