drowe67 / freedv-gui

GUI Application for FreeDV – open source digital voice for HF radio
https://freedv.org/
GNU Lesser General Public License v2.1
206 stars 52 forks source link

Last version compilation failed #309

Closed UgoPoddine closed 1 year ago

UgoPoddine commented 1 year ago

Hello Mooner,

How are you ? Thank-you for your work, really appreciated. The today update with the last release of FreeDV on my Raspberry Pi3+ with up do date pi OS 32 bits failed. See the last part of the log in the attachment. Feel free to ask if you need further details.

Best regards @Ugo Screenshot_20221204-164325

tmiw commented 1 year ago

This is a known issue. See https://github.com/drowe67/LPCNet/issues/49 and https://github.com/drowe67/LPCNet/pull/50.

As a workaround, you can update LPCNET_BRANCH in build_linux.sh to ms-rpi-build instead of master. Let me know if that doesn't work for you.

UgoPoddine commented 1 year ago

Hi Mooner,

The issue was almost known, but till last version (7 days ago) I have always compiled using the build_linux script on the PI without issues No problem at all, I will try the workaround tomorrow morning.

Thanks Best regards, 73 Ugo

Il giorno 4 dic 2022, 19:37, alle ore 19:37, Mooneer Salem @.***> ha scritto:

This is a known issue. See https://github.com/drowe67/LPCNet/issues/49 and https://github.com/drowe67/LPCNet/pull/50.

As a workaround, you can update LPCNET_BRANCH in build_linux.sh to ms-rpi-build instead of master. Let me know if that doesn't work for you.

-- Reply to this email directly or view it on GitHub: https://github.com/drowe67/freedv-gui/issues/309#issuecomment-1336487101 You are receiving this because you authored the thread.

Message ID: @.***>

UgoPoddine commented 1 year ago

Hi Mooner,

the workaround you have proposed allows the compilation to proceed, but not to end correctly : With this change to build_linux.sh :

[..]

change this when working on combined codec2/freedv-gui changes

CODEC2_BRANCH=ms-rpi-build LPCNET_BRANCH=ms-rpi-build

[..]

...this is the final effect :

[..]

Scanning dependencies of target test_vec [ 79%] Building C object src/CMakeFiles/test_vec.dir/test_vec.c.o /home/pi/FreeDV/freedv-gui/LPCNet/src/test_vec.c: In function ‘test_sgemv_accum16’: /home/pi/FreeDV/freedv-gui/LPCNet/src/test_vec.c:75:5: warning: implicit declaration of function ‘sgemv_accum16_fast’; did you mean ‘sgemv_accum16’? [-Wimplicit-function-declaration] 75 | sgemv_accum16_fast(out_fast, weights, ROWS, COLS, 1, x); | ^~~~~~ | sgemv_accum16 /home/pi/FreeDV/freedv-gui/LPCNet/src/test_vec.c: In function ‘test_sparse_sgemv_accum16’: /home/pi/FreeDV/freedv-gui/LPCNet/src/test_vec.c:109:5: warning: implicit declaration of function ‘sparse_sgemv_accum16_fast’; did you mean ‘sparse_sgemv_accum16’? [-Wimplicit-function-declaration] 109 | sparse_sgemv_accum16_fast(out_fast, w, rows, indx, x); | ^~~~~~~~~ | sparse_sgemv_accum16 [ 80%] Linking C executable test_vec /usr/bin/ld: CMakeFiles/test_vec.dir/test_vec.c.o: in function test_sgemv_accum16': /home/pi/FreeDV/freedv-gui/LPCNet/src/test_vec.c:75: undefined reference tosgemv_accum16_fast' /usr/bin/ld: CMakeFiles/test_vec.dir/test_vec.c.o: in function test_sparse_sgemv_accum16': /home/pi/FreeDV/freedv-gui/LPCNet/src/test_vec.c:109: undefined reference tosparse_sgemv_accum16_fast' collect2: error: ld returned 1 exit status make[2]: [src/CMakeFiles/test_vec.dir/build.make:103: src/test_vec] Error 1 make[1]: [CMakeFiles/Makefile2:1286: src/CMakeFiles/test_vec.dir/all] Error 2 make: *** [Makefile:182: all] Error 2 [..]

Please advise. Thank-you Ugo

tmiw commented 1 year ago

A few things:

  1. CODEC2_BRANCH should still be master. Only LPCNET_BRANCH should change.
  2. You may need to rm -rf codec2 LPCNet build_linux before re-attempting the build to clear out anything CMake still has cached.

If you still have issues after (1) and (2) above then I can see about getting 32 bit Raspberry Pi OS running on my 4B for further debugging.

tmiw commented 1 year ago

BTW I was able to get a build environment installed on an older Pi and resolve the issue you're having, so definitely try again. 👍

UgoPoddine commented 1 year ago

Hi Mooner,

using :

[...]

change this when working on combined codec2/freedv-gui changes

CODEC2_BRANCH=master LPCNET_BRANCH=ms-rpi-build

[..]

I was also able to compile the new version. I will try it this evening.

Thank-you Ugo

UgoPoddine commented 1 year ago

Thank-you Mooner (and David)

U