drowe67 / freedv-gui

GUI Application for FreeDV – open source digital voice for HF radio
https://freedv.org/
GNU Lesser General Public License v2.1
206 stars 52 forks source link

QO-100 frequency in FreeDV GUI #324

Closed sp2ong closed 1 year ago

sp2ong commented 1 year ago

When I try put frequency QO-100 manually in kHz 10489640.0 in filed "Report Frequency" ( in Options I have enabled "PSK Reproter ") the frequency is displayed in red colour. It looks like I can put in "Report Frequency" a bigger frequency than 2147483.647 kHz.

In config .freedv is stored FrequencyHz in Hz so for frequency for QO-100 should be in Hz value 10489640000

The value of this is type INT which has a limit in C++ to -2147483648 to 2147483647 so QRG QO-100 is not in this range, for this reason, is not correctly stored in the config file and not correctly reread

For QO-100 frequency in Hz would be instead INT rather type:

long long : -9223372036854775808 to 9223372036854775807 or unsigned long long : 0 to 18446744073709551615

it will allow stored in .freedv QRG QO-100 in Hz and allow use of any frequency in PSKRepoert up to 10 Ghz band

but I'm not a programmer, it is only my analysis problem use "Report Frequency" bigger than 2.1 Ghz

I use the version compiled under Linux:

https://github.com/drowe67/freedv-gui/releases/tag/v1.8.6-20221217

freedv-ver

qo-100-qrg

sp2ong commented 1 year ago

Thank you.

I have tried the new branch ms-freq-precision and I put QRG for QO-100 10489640.0 is displayed now correctly but when I exit from GUI and start again the frequency is displayed with a small difference 10489639.9 I think it is not a critical problem :-)

In the file .freedv is FrequencyHzStr=10489639900

screenshot1 screenshot2

tmiw commented 1 year ago

Try pulling down the latest from that branch and trying again? I just checked in a minor change that seems to resolve that on my end, anyway.

sp2ong commented 1 year ago

Ok,

I updated sources and during compilation, I see one warning only:

freedv/freedv-gui/src/main.cpp: In member function ‘void MainFrame::OnTimer(wxTimerEvent&)’: /freedv/freedv-gui/src/main.cpp:1299:45: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare] 1299 | if (m_timeSinceSyncLoss >= wxGetApp().m_statsResetTimeSec) | ~~~~^~~~~~~~~

The new sources work OK now, I put manually 10489640.0 kHz frequency and after exiting and run again GUI frequency is displayed without a problem

Thanks

screenshot3

sp2ong commented 1 year ago

I try to check this version to send report to PSKReporter I create file with freedv 700D mode and text add callsign and play this file in FreeDV GUI use Tools -> Start Play file form radio. When I put manually frequency like 7177.0 kHz in "Report frequency" in console I see that was sent to PSKReporter report like:

Adding call sign SP2RXY @ SNR 24, freq 7177000 to PSK Reporter.

and on PSKReporter map display information correctly that I received traffic on FreeDV from SP2RXY on frequency 7.177 Mhz

I changed frequency to 10489640.0 kHz i play again y test file and in console I see

Adding callsign SP2RXY @ SNR 24, freq 10489640000 to PSK Reporter.

but on PSKReporter map I see

screenshot

It is loo like is problem with report sending to PSKReport with QRG 10489.640 Mhz where display frequency 0.000 Mhz (invalid)

When use frequency 2147483.0 kHz the report PSKreporter is correct

screenshot1

sp2ong commented 1 year ago

I see on PSKReproter reprts on 10 Ghz for example Mode FT8 from QO-100

screenshot2

tmiw commented 1 year ago

I checked out how MSHV was doing it and it seems that they send a 5 byte location field instead of 4 (like what WSJT-X, FreeDV, etc. do) I updated the PR branch to also use 5 bytes and it seems to work okay here; please confirm.

sp2ong commented 1 year ago

Hi,

I will check the new version.

During compilation the latest version branch ms-freq-precision show two warrings:

screenshot

tmiw commented 1 year ago

During compilation the latest version branch ms-freq-precision show two warrings:

Should be fixed as of the latest commit. The difficulty is that I was fixing it on macOS but causing the warning to pop up on Linux (and vice versa).

sp2ong commented 1 year ago

Hi,

I have updated, and now compiled it clearly :-) without warning.

But in the latest version I have a problem with the console shows that

Adding callsign SP2RXY @ SNR 24, freq 7177000 to PSK Reporter. Adding callsign SP2RXY @ SNR 24, freq 10489640000 to PSK Reporter.

but I don't see a report on PSKReport map any report on band 40 m and 10 GHz

I check band 40m on 1.8.6-dev and the report is displayed on map but from the latest version branch ms-freq-precision no report is shown for example for 7177.0 kHz and for 10489640.0 kHz In the previous version, it showed for 7177.0 kHz but wrongly showed for 10489640.0 kHz

tmiw commented 1 year ago

I just tried playing a test file back in the FreeDV application using the PR branch. It looks like it properly reported when Hamlib was enabled and the radio was on 20 meters and also when I manually entered a 10 GHz frequency. However, I did notice that the PSK Reporter website has been pretty glitchy tonight so it's possible that the server didn't pick up your report. I'd git pull the latest from that branch and try again over the course of the next day or two to make sure.

sp2ong commented 1 year ago

OK,

I will do the tests again in the evening and tomorrow to confirm that it works OK

73 Waldek

sp2ong commented 1 year ago

I have tried many times. When I use the GUI of the latest version 1.8.6-devel and I manually set the frequencies from 3.6 to 28 Mhz each report is shown on PSKReporter

When I use the latest version of ms-freq-precision and manually set the frequencies between 3.6 and 28 Mhz no report is shown on PSKReporter even though in the console it shows that it sent this report

The version of ms-freq-precision that I use is:

screenshot

sp2ong commented 1 year ago

I monitor port UDP 4739 which is used to send report to PSKRreporter host under Linux

tcpdump -nXX -i eth0 dst port 4739

I set frequency manually 21313.0 kHz

and when use FreeDV GUI 1.8.6-devl I see traffic in following

screenshot

but when I use FreeDV GUI branch ms-freq-precises and I set frequency manually 21313.0 kHz

UDP frame looks like below

screenshot

but is not decoded by PSKReporter ??

tmiw commented 1 year ago

Looks like I forgot to add 1 to another location in the PSKReporter class to account for the extra byte sent for the frequency. I might not have encountered the issue before due to (a) my callsign being shorter and (b) the code including padding on 32 bit alignment. Pull down the latest and try again?

sp2ong commented 1 year ago

It seems that the latest patch has solved the problem with decoding reports on PSKReporter. I tried different HF/VHF/UHF/Microwave frequencies entering manually and every report was shown correctly on the map.

It would be nice for PR ms-freq-precisions to be in version 1.8.6-devel because maybe during the coming of Christmas week there will be some activity on QO-100 this could be checked on transmitting stations and not on test files :-)

Thanks and best regards

Waldek SP2ONG