search

drowe67 / freedv-gui

GUI Application for FreeDV – open source digital voice for HF radio
https://freedv.org/
GNU Lesser General Public License v2.1
206 stars 52 forks source link

Options - Debugging and VoiceKeyer tabs can be truncated as window is resized #327

Closed Tyrbiter closed 1 year ago

Tyrbiter commented 1 year ago

This is a similar problem to https://github.com/drowe67/freedv-gui/issues/322 where the window is allowed to reduce width to the point where the right hand ends are truncated.

A little truncated: options-debugging

This is the worst example: options-voicekeyer

Tyrbiter commented 1 year ago

Also note something odd about the Debugging txrxThreadPriority checkbox, it always appears enabled at restart and doesn't seem to prevent the debug output it controls.

tmiw commented 1 year ago

Created PR #328 for the truncation issue. Please confirm that it resolves the problem on your end.

Also note something odd about the Debugging txrxThreadPriority checkbox, it always appears enabled at restart and doesn't seem to prevent the debug output it controls.

This doesn't actually control debugging output, just whether the TX/RX processing threads run at the highest priority. The state of this setting doesn't get saved anywhere, though, so I wonder if we actually need this to be configurable.

Tyrbiter commented 1 year ago

OK, after a pause for seasonal shopping I have now built and tried this out and it's behaving well for me, so the original issue is fixed.

Top work @tmiw, you clearly comprehend this wxWindows stuff well.

The thread priority control is not critical, especially as it wasn't clear what it did and seems happy to be left enabled.

tmiw commented 1 year ago

Thanks, the changes have now been merged. 👍