With installing freedv_1.8.8-devel-2023-01-17-_amd64.deb 'Version' field value '1.8.8-devel-2023-01-17-': revision number is empty

[computer-wizard]

[v1.8.8-20230116] FreeDV is compiled from source (freedv-gui-1.8.8-20230116.tar.gz) and packages are made OS: Ubuntu 22.04

Installing freedv_1.8.8-devel-2023-01-17-_amd64.deb gives the following error:

dpkg: error processing archive freedv_1.8.8-devel-2023-01-17_amd64.deb (--install): parsing file '/var/lib/dpkg/tmp.ci/control' near line 9 package 'freedv': 'Version' field value '1.8.8-devel-2023-01-17-': revision number is empty Errors were encountered while processing: freedv_1.8.8-devel-2023-01-17_amd64.deb

With other words, deb package is not correctly made.

[tmiw]

Are you trying to use make package / cpack to generate the package, or some other mechanism?

[computer-wizard]

I did use cpack.

On 2023-01-18 01:48, Mooneer Salem wrote:

Are you trying to use |make package| / |cpack| to generate the package, or some other mechanism?

— Reply to this email directly, view it on GitHub https://github.com/drowe67/freedv-gui/issues/342#issuecomment-1386569593, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3K5D76FDYEDGPY4CXC6ALWS6G5LANCNFSM6AAAAAAT6O46OA. You are receiving this because you authored the thread.Message ID: @.***>

-- There is nothing permanent except change

-Heraclitus

[tmiw]

cpack seems to work for me (Ubuntu 22.04 LTS) when using the cloned Git source tree:

$ git clone https://github.com/drowe67/freedv-gui.git
$ cd freedv-gui
$ ./build_linux.sh pulseaudio
...
$ cd build_linux
$ cpack
...
CPack: - package: /home/mooneer/freedv-gui/build_linux/freedv_1.8.8-devel-2023-01-19-2d579f6_amd64.deb generated.
$

Anyway, I think replacing line 518 of CMakeLists.txt with the following will resolve the issue when building from released .tar.gz files:

if(FREEDV_HASH)
set(CPACK_PACKAGE_VERSION_PATCH "${CPACK_PACKAGE_VERSION_PATCH}-${FREEDV_VERSION_TAG}-${DATE_RESULT}-${FREEDV_HASH}")
else(FREEDV_HASH)
set(CPACK_PACKAGE_VERSION_PATCH "${CPACK_PACKAGE_VERSION_PATCH}-${FREEDV_VERSION_TAG}-${DATE_RESULT}")
endif(FREEDV_HASH)

(let me know if it does)

Also, I'm not fully sure what the use case of being able to run cpack from tarballs is, though, especially since it's intended for distro package maintainers to generate official packages (at least for non-prerelease builds). Clarification on that would be appreciated for sure.

[computer-wizard]

Those lines did solve it. About these tarballs, they are offered, so it seems be logic to be able to run cpack.

Thanks Mooneer

On 2023-01-18 21:33, Mooneer Salem wrote:

|cpack| seems to work for me (Ubuntu 22.04 LTS) when using the cloned Git source tree:

|$ git clone https://github.com/drowe67/freedv-gui.git $ cd freedv-gui $ ./build_linux.sh pulseaudio ... $ cd build_linux $ cpack ... CPack: - package: /home/mooneer/freedv-gui/build_linux/freedv_1.8.8-devel-2023-01-19-2d579f6_amd64.deb generated. $ |

Anyway, I think replacing line 518 of |CMakeLists.txt| with the following will resolve the issue when building from released .tar.gz files:

|if(FREEDV_HASH) set(CPACK_PACKAGE_VERSION_PATCH "${CPACK_PACKAGE_VERSION_PATCH}-${FREEDV_VERSION_TAG}-${DATE_RESULT}-${FREEDV_HASH}") else(FREEDV_HASH) set(CPACK_PACKAGE_VERSION_PATCH "${CPACK_PACKAGE_VERSION_PATCH}-${FREEDV_VERSION_TAG}-${DATE_RESULT}") endif(FREEDV_HASH) |

(let me know if it does)

Also, I'm not fully sure what the use case of being able to run |cpack| from tarballs is, though, especially since it's intended for distro package maintainers to generate official packages (at least for non-prerelease builds). Clarification on that would be appreciated for sure.

Message ID: @.***>

-- There is nothing permanent except change

-Heraclitus

[tmiw]

Glad that workaround is doing okay for you!

As I'm still not sure if that change is going to go in, I'm going to keep this open for now until I get further guidance from the rest of the team.