Closed wkazubski closed 1 year ago
Can you confirm what version of wxWidgets and openSUSE you're running? I remember it building fine on recent Ubuntu but I could be running a different version of something.
I noticed this error both on openSUSE Leap 15.4 (wxWidgets 3.0.5) and openSUSE Tumbleweed (wxWidgets 3.2.1)
I'm not sure why I was still able to build Windows and macOS binaries (using Clang) without any problems and why the GitHub build actions worked, but PR #344 compiles for me on Tumbleweed. Please go ahead and confirm and I can merge. Thanks for reporting! 👍
The patch helps for both openSUSE distributions. OK to merge. Thanks
Hello! While building release 1.8.7 of freedv on openSUSE, I got this error:
~~~~~~~^~~~~ /home/wk/rpmbuild/BUILD/freedv-gui-1.8.7/src/dlg_easy_setup.cpp:806:25: error: cannot convert 'wxString' to 'const char*' 806~~~~~In file included from /home/wk/rpmbuild/BUILD/freedv-gui-1.8.7/src/dlg_easy_setup.h:29: /home/wk/rpmbuild/BUILD/freedv-gui-1.8.7/src/serialport.h:32:34: note: initializing argument 1 of 'bool Serialport::openport(const char*, bool, bool, bool, bool)' 32 | bool openport(const char port[], bool useRTS, bool RTSPos, bool useDTR, bool DTRPos); |
~~~^~make[2]: *** [src/CMakeFiles/freedv.dir/build.make:93: src/CMakeFiles/freedv.dir/dlg_easy_setup.cpp.o] Error 1 make[2]: Leaving directory '/home/wk/rpmbuild/BUILD/freedv-gui-1.8.7/buildThe previous relase was building OK, but there files dlg_easy_setup.* were not there.