drowe67 / freedv-gui

GUI Application for FreeDV – open source digital voice for HF radio
https://freedv.org/
GNU Lesser General Public License v2.1
193 stars 49 forks source link

Fix issue causing delayed filter updates when going from tracking band to frequency. #704

Closed tmiw closed 5 months ago

tmiw commented 5 months ago

This PR resolves an issue discovered by @barjac in #703 where updates to the displayed list don't occur immediately when switching from tracking band to frequency, but do update the next time the user receives an update from the server for the users not matching the current filter.

barjac commented 5 months ago

Using current master at #10ea1 in QSO I am seeing a very annoying flicker every time my reporter updates, which affects all reporting stations in the table which is set to track freq. The whole table flashes white briefly every 5 seconds. (Using a light theme) If 'only' the text was refreshed then it would not be such an annoyance, it's the whole table colour change from orange and blue (or red and green) to white and back that is the main problem.

tmiw commented 5 months ago

Using current master at #10ea1 in QSO I am seeing a very annoying flicker every time my reporter updates, which affects all reporting stations in the table which is set to track freq. The whole table flashes white briefly every 5 seconds. (Using a light theme) If 'only' the text was refreshed then it would not be such an annoyance, it's the whole table colour change from orange and blue (or red and green) to white and back that is the main problem.

Can you try https://github.com/drowe67/freedv-gui/pull/710 and let me know if that works any better?

barjac commented 5 months ago

Yes that seems perfect! :) Sorry for the delay but I wanted to use it in a net to be sure all was well. The only flash now is when actually switching the mode between Band and freq in either direction which is not a problem.