search

drowzy / ssh_tunnel

MIT License
35 stars 6 forks source link

Feature/other args #2

Closed kylewhite21 closed 10 months ago

kylewhite21 commented 11 months ago

Small change to allow more args to connect/1. I specifically needed to supply a ssh key passphrase. I also moved host and port to new args.

I haven't changed any docs or the README. I can make those edits if you want to pull this in.

drowzy commented 10 months ago

Thanks for the PR! Unrelated question, have you checked if your use case can be covered by using https://www.erlang.org/doc/man/ssh#tcpip_tunnel_to_server-5 (available since OTP-23)? That might be a more stanzdardized way of doing it. When I wrote this lib, that functionality was not yet in OTP.

kylewhite21 commented 10 months ago

Hmm that function does seem to be exactly what I need. I'll have to try it out shortly. Thanks for pointing it out!

kylewhite21 commented 10 months ago

Thanks for the hint, that function is exactly what I needed. It's simplified a lot of things. But thanks for having this code to get me off the ground!