search

droxit / roxcomposer

This is the droxit microservice framework repository.
GNU Lesser General Public License v3.0
5 stars 0 forks source link

server crash when starting service with invalid parameters #86

Closed droxit-becker closed 5 years ago

droxit-becker commented 5 years ago

ROXcomposer crashes when a service is started that has invalid parameters in the parameter json ('logging' : {'level':'INFO'})

Traceback (most recent call last): File "/home/janabecker/PycharmProjects/roxgui/roxgui/service data/topicmatcher.py", line 186, in service = TopicMatcher(kwargs) File "/home/janabecker/PycharmProjects/roxgui/roxgui/service data/topicmatcher.py", line 94, in init self.listen() File "/home/janabecker/.local/lib/python3.6/site-packages/roxcomposer/base_service.py", line 236, in listen self.listen_to(self.params['ip'], self.params['port']) File "/home/janabecker/.local/lib/python3.6/site-packages/roxcomposer/base_service.py", line 224, in listen_to self.on_message(self.roxcomposer_message.payload, self.roxcomposer_message.id) File "/home/janabecker/PycharmProjects/roxgui/roxgui/service data/topicmatcher.py", line 109, in on_message if isinstance(dispatch_msg["fields"], list): # if the message has a fields parameter handle as JSON TypeError: string indices must be integers Traceback (most recent call last): File "/home/janabecker/PycharmProjects/roxgui/roxgui/service data/topicmatcher.py", line 191, in service = TopicMatcher(kwargs) File "/home/janabecker/PycharmProjects/roxgui/roxgui/service data/topicmatcher.py", line 88, in init super().init(params) File "/home/janabecker/.local/lib/python3.6/site-packages/roxcomposer/base_service.py", line 75, in init self.logger = LoggingClass(self.params['name'], logger_params) TypeError: type object argument after must be a mapping, not str undefined:1 nitor.basic_monitoring.BasicMonitoring"}, "service": "topicmatcher"} ^

SyntaxError: Unexpected token i in JSON at position 1 at JSON.parse () at line (/home/janabecker/Documents/Stuff/roxcomposer/build/roxcomposer-demo-0.4.0/api-server/plugins/roxcomposer_control.js:740:32) at Array.filter () at LogSession.receive_lines (/home/janabecker/Documents/Stuff/roxcomposer/build/roxcomposer-demo-0.4.0/api-server/plugins/log_session.js:44:11) at subscribers.forEach (/home/janabecker/Documents/Stuff/roxcomposer/build/roxcomposer-demo-0.4.0/api-server/plugins/log_observer.js:103:11) at Set.forEach () at fs.read (/home/janabecker/Documents/Stuff/roxcomposer/build/roxcomposer-demo-0.4.0/api-server/plugins/log_observer.js:102:25) at FSReqWrap.wrapper [as oncomplete] (fs.js:658:17)

hecktor-droxit commented 5 years ago

See issue https://github.com/droxit/roxcomposer/issues/102.