search

droyo / styx

Go library for the 9P filesystem protocol
MIT License
64 stars 18 forks source link

Revert incorrect `Rwalk` changes, introduce additional test #32

Closed zakkor closed 2 years ago

zakkor commented 2 years ago

Reverts incorrect changes introduced in #30, which broke Rwalk (for which there were failing tests that went unnoticed).

Also removes a superfluous Put call in qidpool: if it already exists, there's no need to Put it, otherwise it gets handled inside the Do block, so still no need for a Put.

In the #30 PR, @seh-msft says:

In the case of a new file being created in the tree, a Twalk, then a Tcreate, would occur.

If there's a new file being created, that means the file doesn't exist yet, which means the Twalk should fail. In the event of an unsuccessful Twalk, no new Qid should be created. I've added a new test that verifies this behaviour is true.

Tcreate should be the only origin of 'new' QIDs to the core file system.

Considering the above, this is still true: Twalk fails, no Qid is created, then Tcreate occurs, and the Qid and file get created.

In conclusion, the current behaviour is correct, so this PR reverts back to that -- there was no need for a fix. I am not sure what issues the original submitter was facing, but I am guessing that they were not coming from styx.

Resolves #31

zakkor commented 2 years ago

Closing this PR in favour of #34, which introduces the same fix, but from a different branch. Github won't let me change the source branch