search

drozhzhin-n-e / ngx-pinch-zoom

Module provides for image zooming and positioning with use of gestures on a touch screen.
http://ivylab.space/pinch-zoom
MIT License
113 stars 95 forks source link

Migration to Angular 13 #104

Open konstantinschuette opened 2 years ago

konstantinschuette commented 2 years ago

Hopefully this was not a waste of time, because the last PR (https://github.com/drozhzhin-n-e/ngx-pinch-zoom/pull/87) was ignored.

Things done:

Maybe someone should take care of more e2e tests. Because there are literally none

konstantinschuette commented 2 years ago

If there is no respone after a week, I will cancel the PR and open up my own package.

turbolego commented 2 years ago

If there is no respone after a week, I will cancel the PR and open up my own package.

There is an Angular 13 package now, but it only goes up to Angular 13.2.x

https://www.npmjs.com/package/ngx-pinch-zoom-13

There's a need for a version of ngx-pinch-zoom that supports 13.3.x

Package "ngx-pinch-zoom-13" has an incompatible peer dependency to "@angular/common" (requires "~13.2.1" (extended), would install "13.3.1").

konstantinschuette commented 2 years ago

If there is no respone after a week, I will cancel the PR and open up my own package.

There is an Angular 13 package now, but it only goes up to Angular 13.2.x

https://www.npmjs.com/package/ngx-pinch-zoom-13

There's a need for a version of ngx-pinch-zoom that supports 13.3.x

Package "ngx-pinch-zoom-13" has an incompatible peer dependency to "@angular/common" (requires "~13.2.1" (extended), would install "13.3.1").

https://www.npmjs.com/package/@meddv/ngx-pinch-zoom

A bit late to the party, but here you go!