search

drpentode / is-gd-shrinker

A quick Ruby API for is.gd URL shrinker
MIT License
2 stars 1 forks source link

URL encoding broken #2

Open shawnwebs opened 13 years ago

shawnwebs commented 13 years ago

When using it with the is.gd example url ("http://maps.google.co.uk/maps?f=q&source=s_q&hl=en&geocode=&q=louth&sll=53.800651,-4.064941&sspn=33.219383,38.803711&ie=UTF8&hq=&hnear=Louth,+United+Kingdom&ll=53.370272,-0.004034&spn=0.064883,0.075788&z=14" from http://is.gd/apishorteningreference.php) it returns a truncated url (/maps?f=q)

That said, I've been experimenting with it and even escaping it isn't returning valid urls (http://is.gd/Oz83Q8-) The url_encode function in the ERB::Util class seems to work fine (http://is.gd/89kQsY-)

I sent a pull request with the patch.

drpentode commented 13 years ago

Sorry for the delayed reply. Could you please add a spec for your fix before I pull it? Thanks.