search

drphilmarshall / Lens-Zoo

Apache License 2.0
0 stars 0 forks source link

Tutorial text not being displayed #49

Closed drphilmarshall closed 10 years ago

drphilmarshall commented 10 years ago

I've had this bug before: the tutorial message boxes display the names of the translate text variables, not their values. I think the problem is that there is some syntax error in the messages but I cannot for the life of me find it. Halp?

chrissnyder commented 10 years ago

Fixed in https://github.com/zooniverse/Lens-Zoo/commit/77ba6790268efbee61d696ea585e779bb34bfa77

Updated merge should do the trick.

drphilmarshall commented 10 years ago

Thanks Chris. That commit fixed most of it - but I still don't see the text in the last few messages. What's the problem BTW? Is it the content syntax?

On Thu, Jan 2, 2014 at 3:59 PM, Chris Snyder notifications@github.comwrote:

Fixed in zooniverse@77ba679https://github.com/zooniverse/Lens-Zoo/commit/77ba6790268efbee61d696ea585e779bb34bfa77

Updated merge should do the trick.

— Reply to this email directly or view it on GitHubhttps://github.com/drphilmarshall/Lens-Zoo/issues/49#issuecomment-31484110 .

chrissnyder commented 10 years ago

Problem I fixed was because the tutorial elements weren't on the page when the language was loaded. So I had to call the translate function again when the step is displayed to load the correct strings.

What part is incorrect? Playing through it here, it looks OK from what I can tell.

drphilmarshall commented 10 years ago

Hmm - have you played it all the way through to the QD and Talk parts? That's what Im missing.

On Thu, Jan 2, 2014 at 4:31 PM, Chris Snyder notifications@github.comwrote:

Problem I fixed was because the tutorial elements weren't on the page when the language was loaded. So I had to call the translate function again when the step is displayed to load the correct strings.

What part is incorrect? Playing through it here, it looks OK from what I can tell.

— Reply to this email directly or view it on GitHubhttps://github.com/drphilmarshall/Lens-Zoo/issues/49#issuecomment-31486388 .

chrissnyder commented 10 years ago

Ah OK, I see.

Steps for the tutorial are declared in https://github.com/drphilmarshall/Lens-Zoo/blob/master/app/lib/tutorial_steps.coffee I can add the QD and Talk steps to the initial tutorial. Should they still show up randomly later on?

drphilmarshall commented 10 years ago

They should show up after 3 and 7 classifications (although TBH I think 4 and 7 would be less hectic). Looks like they need the same translation treatment. Great if you can fix them the same way you did the others! Thanks :-)

On Thu, Jan 2, 2014 at 4:58 PM, Chris Snyder notifications@github.comwrote:

Ah OK, I see.

Steps for the tutorial are declared in https://github.com/drphilmarshall/Lens-Zoo/blob/master/app/lib/tutorial_steps.coffeeI can add the QD and Talk steps to the initial tutorial. Should they still show up randomly later on?

— Reply to this email directly or view it on GitHubhttps://github.com/drphilmarshall/Lens-Zoo/issues/49#issuecomment-31488382 .

chrissnyder commented 10 years ago

Fixed!

drphilmarshall commented 10 years ago

Great, thanks! :-)