search

drphilmarshall / OM10

Tools for working with the Oguri & Marshall (2010) mock catalog of strong gravitational lenses
MIT License
8 stars 19 forks source link

Improved speed #53

Closed jennykim1016 closed 7 years ago

jennykim1016 commented 7 years ago

I fixed a few lines in both db.py and plotting.py to improve functionality and speed. Could you check the updates please?

ps. I remember you advising that having two same directories in my computer is generally not a good idea. Then, for these kinds of cases, would it be better to wait until the pull request is accepted and then update my om10 package locally?

ps2. I realized that my original, forked directory contains the files that I have been changing. Thus, making a new branch in the forked directory also contains those changed files. Would you be able to just accept plotting.py and db.py? If not, I think I would have to make a branch that does not contain those updates.

Thank you so much! Have a nice evening.

jennykim1016 commented 7 years ago

I think I moved all the unnecessary notebooks, .pyc files, and .ipynb_checkpoints. Github does not allow searching files using the keywords(i.e. .pyc) in the forked directory, but I think I manually browsed into each folders and deleted all the unnecessary files. Could you check my master's directory again please?

Thank you!

drphilmarshall commented 7 years ago

I think all the commits in this PR have been merged in via #57, which (I think) superceded it. Right, @jennykim1016 ?

jennykim1016 commented 7 years ago

Yes! Thanks.