search

drphilmarshall / OM10

Tools for working with the Oguri & Marshall (2010) mock catalog of strong gravitational lenses
MIT License
8 stars 19 forks source link

Python 3 compatibility #63

Closed drphilmarshall closed 6 years ago

drphilmarshall commented 6 years ago

I'm using this PR to have travis test python 3.5 as well as 2.7. Closes #62 when merged.

drphilmarshall commented 6 years ago

Hmm. I'm not sure why travis is failing - something wrong with the way it is being setup? @jchiang87 do you mind checking out the issue/62/py3 branch and running nosetests please? You'll need to do a python setup.py develop in the om10 dir first.

drphilmarshall commented 6 years ago

PS. I think I made om10 correctly python 2 and 3 compatible.

jchiang87 commented 6 years ago

@drphilmarshall I'm having problems setting up this package on my laptop. Where can I get the indexTricks package? Also, I think LensPop will need a python3 compatibility sweep.

drphilmarshall commented 6 years ago

Issued python 3 compatibility work in my fork of LensPop at https://github.com/drphilmarshall/LensPop/issues/3

BTW indexTricks.py is a module in the top level of my fork of LensPop - so that's a packaging issue that needs fixing...

drphilmarshall commented 6 years ago

OK, @jbkalmbach fixed the python 3 compatibility in OM10 and in lenspop, so we should be good - though it'd be nice to see travis pass...

drphilmarshall commented 6 years ago

... close, but py 3.5 fails (an import distance error in lenspop): here's the travis log

drphilmarshall commented 6 years ago

@jbkalmbach you've cracked it: travis now passes. Merging - and thank you for making this work! :-)