search

drphilmarshall / Pangloss

Line of sight mass reconstruction in the Universe
GNU General Public License v2.0
10 stars 10 forks source link

dead notebooks and scripts #111

Open davidthomas5412 opened 8 years ago

davidthomas5412 commented 8 years ago

Problem: I don't believe the notebooks that are not on the index list will be used. I also think that once we have a likelihood notebook, then the scripts in tests will also probably no longer be used. It can be a nuisance to continue to support notebooks and scripts as we make api changes that impact them when they will no longer be used. It is also more source code to search through when looking things up/making changes, the notebooks in particular have a lot of js/css metadata that clogs text searches.

Solution: We should probably remove these dead notebooks/scripts or have them moved into a different branch. What do you guys - @drphilmarshall and @sweverett - think?

drphilmarshall commented 8 years ago

I'd be in favor of making an "attic" folder and moving old stuff into there. My rule about "attic"s is: "don't look in the attic!" But sometimes its useful to go digging through them to find a snippet you need. A minimal set of good demo notebooks sounds like a good plan to me.

On Thu, Oct 27, 2016 at 6:09 PM, David Thomas notifications@github.com wrote:

Problem: I don't believe the notebooks that are not on the index list will be used. I also think that once we have a likelihood notebook, then the scripts in tests will also probably no longer be used. It can be a nuisance to continue to support notebooks and scripts as we make api changes that impact them when they will no longer be used. It is also more source code to search through when looking things up/making changes, the notebooks in particular have a lot of js/css metadata that clogs text searches.

Solution: We should probably remove these dead notebooks/scripts or have them moved into a different branch. What do you guys - @drphilmarshall https://github.com/drphilmarshall and @sweverett https://github.com/sweverett - think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/drphilmarshall/Pangloss/issues/111, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY917Sbdah-mQmuHtpWwYakLPEZrR0ks5q4UtZgaJpZM4Ki-8C .

drphilmarshall commented 8 years ago

OK, @davidthomas5412 pointed out that an attic folder still clogs up searching etc.

@sweverett we have made a "release" labelled "Everett 2016" to tag the repo with all your senior thesis work: this now frees up David to streamline the repo. We can just look at the released version to find your old demo notebooks and scripts:

https://github.com/drphilmarshall/Pangloss/releases/tag/Everett2016

@davidthomas5412 Please do go ahead with your clean-up!