drpout / boilr

Price alarms for Bitcoin, cryptocurrencies, cryptoassets, futures and options.
http://boilr.mobi
GNU General Public License v3.0
128 stars 67 forks source link

Constant names should comply with a naming convention #231

Closed AymanDF closed 7 years ago

AymanDF commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S00115 - “Constant names should comply with a naming convention”. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S00115 Please let me know if you have any questions. Ayman Abdelghany.

dllud commented 7 years ago

Won't merge this one. We'll opt for code clarity instead of naming conventions. In this particular case we believe it is better to keep the current constant names for sake of easier code reading.