drpout / boilr

Price alarms for Bitcoin, cryptocurrencies, cryptoassets, futures and options.
http://boilr.mobi
GNU General Public License v3.0
128 stars 67 forks source link

build latest version #281

Open popbangshwang opened 6 years ago

popbangshwang commented 6 years ago

Hello, just wondering if you would mind building the latest version, libdynticker seems to support binance already, just need to release a build of boilr with it. It would be very much appreciated if you could.

Thanks in advance.

gitowok commented 6 years ago

@dllud - is this a simple case of putting together a build environment and building from latest master branch, or would there be changes required to the gui to enable binance and newer exchanges from libdynticker?

dllud commented 6 years ago

No changes required. It's all on the master branch already. I just need to release a proper build. I didn't find the time yet.

gitowok commented 6 years ago

awesome.

gitowok commented 6 years ago

Well I spent a few hours today trying to get my head around maven and the android SDK from cold, but I'm throwing in the towel as i have no idea what i'm doing without probably another 5+ more hours. This is beyond my threshold of pain, for a once off task of "build the project and give people an APK link".

@dllud - pretty pretty please - hit compile for us?

dllud commented 6 years ago

@gitowok I will try to build it this weekend. Sorry for the delay. It's not just a matter of hitting a button. Many more task have to be done, hence I have to get an entire free day for this.

gitowok commented 6 years ago

another friendly bump.. binance and kucoin are heavily used now, both missing from boilr. Cheers

dllud commented 6 years ago

Thanks for the reminder. I am aware. It will be done sooner rather than later.

gitowok commented 6 years ago

I still check every weekend! :)

dllud commented 6 years ago

Thanks for keeping up and sorry for the long delay. I will let you know here as soon as I release a new build. It's just that spare time has been so scarce…

Eimuex commented 5 years ago

Hello, does it means that if I build apk from master source I will have binance? I don't know how to do it but I'll give it a try if that's the case.

gitowok commented 5 years ago

Yes. Please post your APK! good luck, i couldnt work it out.

Eimuex commented 5 years ago

I'm stuck with this error: [ERROR] Failed to execute goal com.simpligility.maven.plugins:android-maven-plugin:4.5.0:generate-sources (default-generate-sources) on project boilr: Execution default-generate-sources of goal com.simpligility.maven.plugins:android-maven-plugin:4.5.0:generate-sources failed: A required class was missing while executing com.simpligility.maven.plugins:android-maven-plugin:4.5.0:generate-sources: javax/xml/bind/annotation/XmlSchema

EDIT: https://github.com/simpligility/android-maven-plugin/issues/778 Successfully done with jdk8

Eimuex commented 5 years ago

I managed to build boilr 0.8.0-rc2 debug apk with libdynticker-0.8.0, but still binance is not shown as choice inside the app. It’s listed inside libdynticker-0.8.0.jar though.

dllud commented 5 years ago

Thanks for the effort @Eimuex ! Yes, it needs to be added to the exchanges lists in Boilr. I am doing that this weekend.

Eimuex commented 5 years ago

@dllud Cool, I have compiled libdynticker jars if you need them, but had to skip some tests due to offline exchanges, don't know if that matters.

gitowok commented 5 years ago

woo.. keep this momentum going guys! @dllud - in case you dont get time, could you give Eimuex some pointers on which file to modify for adding binance?

Eimuex commented 5 years ago

Yes please. I tried to find relevant lists without success. If you are over-occupied I could try to make it work, though I’m not programmer and probably can’t deal with complex stuff.

Eimuex commented 5 years ago

I compiled printexchanges with mvn compile exec:java -P xml and got classes folder without xml. Don't know how to include it into boilr.

gitowok commented 5 years ago

@Eimuex - well done re compiling. If you have time can you document rough steps to set up the build environment? I'd like to give it another go myself. Also, does bitmex exchange work on your compiled version? (it was already in old version just not working)

Eimuex commented 5 years ago

I installed jdk-8 and android sdk 28 first. Then compiled libdynticker and placed jar and pom into /home/user/.m2/repository/mobi/boilr/libdynticker/0.8.0 . After that I exported paths for sdk and followed steps from https://github.com/drpout/boilr to compile bolir (in step 3 I used ‘android-28’ instead of 26). Also I used ‘debug’ cause I don’t know how to sign apk. Bitmex is working on this version as I can see.

Eimuex commented 5 years ago

@gitowok Any luck?

gitowok commented 5 years ago

Hi all. I finally got around to this. Thanks to the great instructions from @Eimuex - and a bit of extra problem solving (had to install the Android 8.0 (API 26) using android sdk manager to get rid of a NullPointerException in findPlatformByApiLevel / android-maven-plugin - even though I specified Android-28 in step 3)

The file to edit before building to get binance support: src/main/res/values/strings_no_translate.xml

Just add "Binance" and "mobi.boilr.libdynticker.exchanges.BinanceExchange" to the relevant lists.

And finally, here's my APK: https://www.jabawok.net/uploads/fixes/boilr-0.8.0-rc2-binance.apk

I really hope this helps someone, and big props to @dllud for work on this excellent app. May we encourage you to do an official build and deploy to f-droid !

dllud commented 5 years ago

Glad to know you were able to build it!

And thanks for the push. Encouragement is not lacking, it is rather a chronic lack of free time. But I will get into it.

algazarra commented 5 years ago

Awesome! Great work

Eimuex commented 5 years ago

@gitowok Great man, thank you!

gitowok commented 4 years ago

I still use this dodgy custom build with bitmex and binance support every day. Its still the only thing with price alarms in f-droid. @dllud - just some more encouragement to spend a couple hours and bump the f-droid version. cheers man.