drpout / boilr

Price alarms for Bitcoin, cryptocurrencies, cryptoassets, futures and options.
http://boilr.mobi
GNU General Public License v3.0
128 stars 67 forks source link

Pinstripe coherence #68

Closed algazarra closed 9 years ago

algazarra commented 9 years ago

There's a pinstripe pattern behind the alarm list. Why not use it on the whole app backgrounds? Settings page, notification, triggered alarm, etc? I'd say, leave android defaults as they are, just try being more coherent where there's the possibility.

dllud commented 9 years ago

We tried that and it becomes a mess. Not having the pinstripe on settings activities allows us to better distinguish them from the app main activity (the alarms' list). Notice that other apps that use pinstripe (Whatsapp, Telegram and Chat Secure) only use it in their main activity (the one which is displayed for longer). Can you do some research on this?

I'll add the pinstripe to all activities and take some screenshots for us to compare.

algazarra commented 9 years ago

Hey, I'm confirming that the textured background is a main window exclusive on most apps.

I'd say to have the textured pinstripe as a background everywhere and then work with the alphas of the several elements. Just as we did for the main. Is this too troublesome? We should do this together, and in our native language. For speed sake!

dllud commented 9 years ago

Here go all the options.

light-alarm-list

light-settings-with-pinstripe light-settings-no-pinstripe

dark-holo-bar-alarm-list

dark-holo-bar-settings-with-pinstripe dark-holo-bar-settings-no-pinstripe

dark-solid-bar-alarm-list

dark-solid-bar-settings-with-pinstripe dark-solid-bar-settings-no-pinstripe

dllud commented 9 years ago

I prefer without pinstripe for both themes and the dark theme with the regular (blue underlined) Holo bar,

On both I would decrease the alpha of the ON alarm row to make them more white/black.

algazarra commented 9 years ago

I prefer the normal holo bar too, but i'd leave settings with the pinstripe.

On both I would decrease the alpha of the ON alarm row to make them more white/black.

do you mean decreasing the on alarm box alpha? wouldn't that make the background more visible? i like it the way it is. wouldn't mind checking it out with different alphas.

dllud commented 9 years ago

Yes, I thought it would be better to have the alarm box background more visible, specially in dark theme, in order to get closer to the action bar colour. But I won't touch it because I am changing other things (read bellow).

I was getting annoyed by the settings lists with pinstripe, specially with the dark theme. Every time I opened them I thought "Why is this different from everything else in my system?". I checked even more apps that use pinstripe (OsmAnd~ and Quickdic) and they all have the settings background in pure black. Then I opened CMFileManager and there was my answer:

cmfilemanager-dark cmfilemanager-light

You must use the pinstripe in the action bar too AND have the blue line separator for both dark and light themes. Now it looks good and coherent:

dark-alarm-list dark-settings dark-triggered-notification

light-alarm-list light-settings light-triggered-notification