drrelyea
commented
5 years ago Hi Matteo,
I had originally coded this for personal use. I'd intended to fix it up and port it over to scipy, as it definitely makes more sense for it to be there as opposed to standalone, but I ended up pursuing other efforts. There's no active development on the project.
I'd be happy to hand it over (or just tacitly accept pushes) if you'd like to get the code up to scipy standards. There are two other people who've provided updates, and one expressed interest in making the library a lot more efficient, but I haven't heard from either of them in months. I don't think either is particularly serious, fwiw.
And yes, you'd definitely have to speak the original Matlab devs.
On Wed, Dec 12, 2018 at 10:50 PM Matteo Ravasi notifications@github.com wrote:
Hello, I am the main developer and mantainer of https://github.com/Statoil/pylops. We will be interest to use sparse solvers for some of our inverse problems and in the past I successfully used SPGL1 in Matlab. I am happy to see that you started porting it to python and would like to ask some questions:
- how active is this project? Are you planning to do some more work, e.g add unittest/pytest
- make proper numpydoc style code docstrings
- avoid using your internal lsqr but use ‘official’ scipy one
- add to pypi (but this may not be needed, read below)
Reason I ask these questions is that I discussed with scipy developers about having more solvers in their suite and they say they are happy to consider including any solver provided that:
- code is to their standards (style, tests, docstring)
- license adheres with their licence policy ( https://docs.scipy.org/doc/scipy/reference/hacking.html)
Please let me know how you feel about this. I can of course contribute and help out getting things in place but as I say I’d be more happy to do it if we agree that this will eventually migrate into scipy instead of being a standalone library :)
PS: if you think this is a good way we will also need to check with the Matlab developers of SPGL1 (since you ported their code) to either change their licence or grant permission to scipy to use a less restrictive one for the scipy version.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drrelyea/SPGL1_python_port/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AFFPdxMbPDb3cOvjXDVVxAoJlQwGY1Chks5u4fi8gaJpZM4ZRB4S .
mrava87
Jwink3101
Hello, I am the main developer and mantainer of https://github.com/Statoil/pylops. We will be interest to use sparse solvers for some of our inverse problems and in the past I successfully used SPGL1 in Matlab. I am happy to see that you started porting it to python and would like to ask some questions.
How active is this project? Are you planning to do some more work, e.g:
Reason I ask these questions is that I discussed with scipy developers about having more solvers in their suite and they say they are happy to consider including any solver provided that:
Please let me know how you feel about this. I can of course contribute and help out getting things in place but as I say I’d be more happy to do it if we agree that this will eventually migrate into scipy instead of being a standalone library :)
PS: if you think this is a good way we will also need to check with the Matlab developers of SPGL1 (since you ported their code) to either change their licence or grant permission to scipy to use a less restrictive one for the scipy version.