search

drrelyea / spgl1

Port of SPGL1 to python
GNU Lesser General Public License v2.1
45 stars 29 forks source link

Fixed #31 #32

Closed mrava87 closed 3 years ago

mrava87 commented 3 years ago

Changed check on array of complex numbers. The previous check led to keeping complex valued arrays when the imaginary part was zero, which created a ComplexWarning in oneprojector, but more importantly made it not behave coherently as this routine is expecting to act on real valued arrays.

theXYZT commented 3 years ago

Would it be worth adding complex problems to the tests? Currently I see that only real-valued problems are tested.

mrava87 commented 3 years ago

Would it be worth adding complex problems to the tests? Currently I see that only real-valued problems are tested.

Mmh there are already some tests for complex valued problems. Happy if you want to add more to review the PR :)

theXYZT commented 3 years ago

Would it be worth adding complex problems to the tests? Currently I see that only real-valued problems are tested.

Mmh there are already some tests for complex valued problems. Happy if you want to add more to review the PR :)

Ah yes, I see it now. I originally only read the beginning of the tests file and saw only real-valued matrices. I see the complex tests now! Thanks :)

mrava87 commented 3 years ago

@drrelyea can you merge this please.

Also, do you mind activate the build on travis-ci.com. I think this used to be on org but it has been ceased over the com site

drrelyea commented 3 years ago

@mrava87 Of course - sorry - thought we were waiting on a unit test.

drrelyea commented 3 years ago

@drrelyea can you merge this please.

Also, do you mind activate the build on travis-ci.com. I think this used to be on org but it has been ceased over the com site

@mrava87 Travis is being weird - not letting me add the repo. I'll look into it more tonight - maybe the existing travis file is confusing it.

mrava87 commented 3 years ago

No worries, @drrelyea. I have experienced the same issue trying to add my local branch. I don't really understand why. Have a look, if we don't manage I can easily add a Github action pipeline, its probably even better as travis is getting less and less reliable lately