Preface
I have not added any tests for this PR because I was unsure how to actually run the test suite. If someone can provide some insight into how to run the suite, I'll add them in whatever tests are required ASAP.
Issue
These examples use code from the gRPC example.
Currently, the generated docblocks for services return:
I think the logic for how docblocks and actual method code are generated can be rewritten to generate them in parallel and merge them into $s after generation, but I'm hesitant to make these changes without knowing how to use the test suite and the maintainer(s) desires.
Preface I have not added any tests for this PR because I was unsure how to actually run the test suite. If someone can provide some insight into how to run the suite, I'll add them in whatever tests are required ASAP.
Issue These examples use code from the gRPC example.
Currently, the generated docblocks for services return:
These doc blocks are
$metadata
and$options
).Proposal Add logic to
DrSlump\Protobuf\Compiler\PhpGenerator@compileStub
to handle the above cases based on the RPC type.It will now return:
I think the logic for how docblocks and actual method code are generated can be rewritten to generate them in parallel and merge them into
$s
after generation, but I'm hesitant to make these changes without knowing how to use the test suite and the maintainer(s) desires.