drsounds / mingus

Automatically exported from code.google.com/p/mingus
GNU General Public License v3.0
0 stars 0 forks source link

[Patch] Python 3 compatibility via 2to3 #108

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I've written a patch that makes it possible to run Mingus under Python 3.

Attempting to maintain a codebase that runs under both python2 and python3 
simultaneously is frequently not worth the hassle, so a standard approach is to 
maintain the codebase in python2 and have python3 users run the "2to3" tool on 
the codebase to convert it.

There were a few places in the code that 2to3 didn't handle: string exceptions, 
integer division, removal of the __cmp__ method, and a weird circular import 
problem. So I've prepared a patch that cleans up those areas.

Incidentally, mingus' thorough test suite meant that these issues were easy to 
detect and fix :-).

The cumulative patch is attached. I've also published my repository as 
http://code.google.com/r/artdent-mingus-python3/, with 4 branches:
- the default branch, with my changes
- the keys branch, merged with the default branch
- the python3 branch, a checked-in result of running 2to3 on the default branch 
(just for demonstration purposes)
- the keys-python3 branch, from running 2to3 on the keys branch

Original issue reported on code.google.com by artdent on 27 Mar 2011 at 9:39

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch! That's very cool :) 

I haven't had much time to work on mingus in the past year, but I'll soon 
schedule some space to close some outstanding bugs, merge in some patches and 
do a new release. 

I will put a mention of your repository on our main page for now so people can 
check it out already, but you should see it soon in trunk/ ;)

Original comment by Rhijnauwen@gmail.com on 27 Mar 2011 at 10:05

GoogleCodeExporter commented 9 years ago
After the merge of the keys branch, I'll apply this patch.

@artdent: do you want to participate directly to the official branch? What do 
you think about?

Original comment by carlo.stemberger@gmail.com on 17 May 2011 at 11:45

GoogleCodeExporter commented 9 years ago
This issue was closed by revision b462928a19d2.

Original comment by carlo.stemberger@gmail.com on 19 May 2011 at 12:01