Closed AlexandrGraschenkov closed 6 years ago
drsrinathsridhar
commented
6 years ago Thanks for noticing this. This indeed seems like a bug, I will take a look.
About your second comment: that's the trade-off you have to make when you want a generic implementation. The models can often be more complex than the actual RANSAC code. You can very well write problem specific RANSAC code in far fewer lines if you wish.
drsrinathsridhar
commented
6 years ago Hi there,
I fixed a minor bug that was causing the black inlier point to be labeled as an outlier.
Briefly, this was because I was not appending the points used for line model computation to the best inliers. This means that 2 inliers (but not more) were being labeled as outliers. This is fixed now.
On your screenshot the black dot also visible near line below green one. Maybe there some error in code.
In my opinion simple example without generic types may have more profit for understanding and usage. There much more code in model, that in GRANSAC.h. It's not bad, but start thinking do we really need this abstraction with templates.