search

drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Allow userratings in usercontext for trakt #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
To better support new Trakt sync feature and rating dialogs, MyFilms should 
support ratings in the user context - the same way, as it is already present 
for "enhanced" watched status handling.
Thus, ratings can be different depending on the (trakt)user.
This requires enabling the "Enhanced Watched Handling"

Original issue reported on code.google.com by Guzz...@googlemail.com on 12 May 2012 at 8:58

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2141.

Original comment by Mikeplan...@web.de on 12 May 2012 at 8:59

GoogleCodeExporter commented 9 years ago

Original comment by Guzz...@googlemail.com on 13 Jun 2012 at 8:02

GoogleCodeExporter commented 9 years ago 
Currently (v2321) My Films does not offer the Trakt Rating Dialog unless the 
rating field is empty or 0.  However, unless you have enabled the advanced 
setting in Trakt to synchronize ratings there is no reason not to display the 
Trakt rating dialog, (when Show Rating Dialog is enable in Trakt) which only 
sends it to Trakt website.

Original comment by Dade...@gmail.com on 1 Aug 2012 at 9:59

GoogleCodeExporter commented 9 years ago 
This is controlled by Trakt plaung - and there by MyFilms handler.
So it should be discussed with / reported to Damien - or I could provide a 
trakt patch for him.

Original comment by Guzz...@googlemail.com on 2 Aug 2012 at 8:55

GoogleCodeExporter commented 9 years ago 
We already discussed it with Damien in a conversation! And he confirmed that 
Trakt ONLY syncs (i.e. overwrites rating field data) if Sync is enabled.  So we 
can safely show rating dialog for MF and submit the Trakt rating to Trakt. 

IIRC it is MF code that only allows the rating dialog to display if rating 
field is not blank/0?  But perhaps I misunderstood.

Original comment by Dade...@gmail.com on 2 Aug 2012 at 9:26

GoogleCodeExporter commented 9 years ago 
No, it is trakt, that is autolaunching that user rating dialog on "playback 
end" method.
There is also a menu entry that allows to manually rate a movie (trakt menu).
So we could either:
- change that trakt behaviour (don't know, if that is possible, as the trakt 
behaviour might be shared wit other plugins)
- let users disable the trakt feature "rate after watched" and add this feature 
in MyFilms.
I would prefer to let trakt handle it, as it is strictly related to trakt and 
doesn't make sense in other environment .... we already have a rating dialog 
for the DB rating ...
Opinions ?

Original comment by Guzz...@googlemail.com on 2 Aug 2012 at 5:00

GoogleCodeExporter commented 9 years ago 
Any comments? If not, I will close the issue.
Changing Trakt MyFilms handler to "always rate" is only changing one line in 
Trakt code - but has to happen there.

Original comment by Guzz...@googlemail.com on 5 Aug 2012 at 6:52

GoogleCodeExporter commented 9 years ago 
Will add user rating as context option.
Question: currently, the DB rating does also send rating info to trakt - this 
should then be disabled, right?

Original comment by Guzz...@googlemail.com on 5 Aug 2012 at 11:22

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2349.

Original comment by Mikeplan...@web.de on 6 Aug 2012 at 12:00

GoogleCodeExporter commented 9 years ago 
When does DB rating get sent to Trakt?  If it is only when user changes the 
rating, via rating dialog then I think it still should (as most users won't 
enter a user rating).

However, I see no reason MF should submit ratings grabbed from websites, 
especially IMDB do you? So when you import a film(s) does MF sync that rating 
to Trakt?

Original comment by Dade...@gmail.com on 8 Aug 2012 at 6:49

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2376.

Original comment by Mikeplan...@web.de on 13 Aug 2012 at 12:19

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2377.

Original comment by Mikeplan...@web.de on 13 Aug 2012 at 12:20

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2381.

Original comment by Mikeplan...@web.de on 14 Aug 2012 at 12:56

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2391.

Original comment by Mikeplan...@web.de on 18 Aug 2012 at 9:09

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2392.

Original comment by Mikeplan...@web.de on 18 Aug 2012 at 10:21

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2394.

Original comment by Mikeplan...@web.de on 18 Aug 2012 at 1:02

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2433.

Original comment by Mikeplan...@web.de on 24 Aug 2012 at 4:29

GoogleCodeExporter commented 9 years ago 
Fixed update of "Favorites" field - if user rates a movie, he will be added to
favorites field when rating > 5 - otherwise be removed.
A view on Favorites field will show all users and their favorite movies.
When not using "enhanced watched mode", only user "Global" will be there.

Original comment by Guzz...@googlemail.com on 24 Aug 2012 at 4:34

GoogleCodeExporter commented 9 years ago 
Nice! However, 'Global' user makes no sense to a user who has never enabled 
enhanced watch mode. If multi-user mode is not enabled,  then Favorites should 
simply display the films list of all movies for Global user.

Personally I think only a rating above 7 or 8 indicates a 'favorite' movie ;)

Original comment by Dade...@gmail.com on 25 Aug 2012 at 12:19

GoogleCodeExporter commented 9 years ago 
Not sure it is a bug, but if you change rating, or watch a movie again and rate 
via Trakt popup rating dialog, you end up with multiple valsue of the user name:

e.g.: "Default,             Dadeo,            Dadeo,           Dadeo,          
Dadeo,         Dadeo,        Dadeo,       Dadeo,      Dadeo,     Dadeo,    
Dadeo,   Dadeo,  Dadeo, Dadeo"

I think it should only add the user name if it is different, or remove it if 
you change the rating to less than x (I still think rating of 5 is too low for 
a 'favorite!'

Original comment by Dade...@gmail.com on 7 Sep 2012 at 9:28

GoogleCodeExporter commented 9 years ago 
Ok, will set Favorite when rating > 7

Original comment by Guzz...@googlemail.com on 8 Sep 2012 at 5:08

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2513.

Original comment by Mikeplan...@web.de on 8 Sep 2012 at 5:09

GoogleCodeExporter commented 9 years ago 
Updated Wiki Docs:
Detail Views - Context Menu re Ratings
Trakt - re pop-up rating dialog 

Added notes about auto add to Favorites if user rating > 7 

Added a FAQ page 'Can I view Favorite films.'

Original comment by Dade...@gmail.com on 9 Sep 2012 at 6:31