drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Selecting Films as default view is broken #143

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Using V6.0.0.2321-(MP12):
1. In Setup, select 'Films' as default start view for Config

What is the expected output? What do you see instead?
Whenever you open MF the Views Menu displays (empty) for 2 seconds, even if you 
just exit and reload MF.

If you go to Details screen and return to main view, the same thing happens 
(mostly empty View Menu displays) This is true no matter what view you select 
as Start View other than Views Menu.

If you do NOT enable 'Display always this view' in Setup, then 
1. MF does NOT display Views Menu when you press Esc/Back
2. Films view is missing data until you select it as a view within MF (see 
attached screenshot)
3. MF Ignores the Start view setting for any view now - it applies only when 
you restart MP and thus is no longer a MF start setting.

Log attached.
Please use labels and text to provide additional information.

Original issue reported on code.google.com by Dade...@gmail.com on 28 Jul 2012 at 2:48

Attachments:

GoogleCodeExporter commented 9 years ago
Additional info - you can also reproduce the above missing data by:
1. Go to Film List
2. Press H to go Home in MP
3. Press Esc to go back to MF

Same applies if you use the Main menu link to TV Shows, then press Esc/back to 
return to MF.

Original comment by Dade...@gmail.com on 28 Jul 2012 at 3:22

GoogleCodeExporter commented 9 years ago
That should already be fixed with latest version 2230 - but will recheck.

Original comment by Guzz...@googlemail.com on 28 Jul 2012 at 1:05

GoogleCodeExporter commented 9 years ago
Sadly no - the issue still exists in build 2338
All the above reported misbehavior is the same.

Original comment by Dade...@gmail.com on 2 Aug 2012 at 4:12

GoogleCodeExporter commented 9 years ago
I am sorry, I cannot reproduce any of the described scenarios or problems.
Please check logs for any error that might have shown up.
Did you create new configs for testing or use any old/migrated ones?
If you can reproduce, please post catalog and myfilms config, so I can try 
reproducing.
Please also test with version >= 2350 - although that area was last 
modified/fixed in 2315...

Original comment by Guzz...@googlemail.com on 6 Aug 2012 at 1:15

GoogleCodeExporter commented 9 years ago
Issues are mostly fixed in build 2354, however:

When you select Films view as the start view there is a delay, and now a dialog 
message displays "My Films Loading" (see attached screenshot) with some skin 
properties displayed (brackets for rating, 0 rating stars, watched icon) - 
perhaps those can be resolved in skin but I am more concerned about the delay, 
even for Sample Movies db (yes new config) which is very small! 'Display only 
this view' makes no difference.

You do not get this delay when selecting any other view as start view, or even 
if you select Films View from the Views Menu.  However as Films view will still 
be the default view for many existing 5.1. users, it does not give a good first 
impression!

Original comment by Dade...@gmail.com on 7 Aug 2012 at 5:54

Attachments:

GoogleCodeExporter commented 9 years ago
there is no longer delay than before - it is just opening the window faster and 
does some work after that.
I just checked here and it is less than 1 second from pressing enter until 
films list (samplemovies, always films) is displayed.
However, there are two conditions that indeed can delay it: latest media 
handler and trakt - they both might open the DB and due to introduced locking 
mechanism, that would block access to DB until they finished their access.
So please test without those plugins if the delay disappears. 
Re visibility: the remaining items' visibility should be solved in skin - 
unless there is proof, that the state (it is "start view") is incorrect (check 
for setDummycontrolsForFacade entries in log).
You can also provide me logs of one entry so I can see, if there is anything 
wrong.
Note: In the past, the previous screen was just frozen until DB loading was 
finished - then showing main screen immideately. That was imho bad experience 
with big catalogs on shares, that could take several seconds to load and give 
user impression it is freezing.
I could disable the progressdialog however e.g. depending on location (so 
disable it for local DBs, that usually are much faster in loading)?

Original comment by Guzz...@googlemail.com on 11 Aug 2012 at 1:43

GoogleCodeExporter commented 9 years ago
Disabling Trakt/LMH did not make any difference :(

I am leaving the issue open until the skin properties issue is solved.

Yes it would be nice to have a nicer screen display - to create a good 
impression when you first open MF with Films view as start view, but that could 
take a while ;)

Original comment by Dade...@gmail.com on 12 Aug 2012 at 5:00

GoogleCodeExporter commented 9 years ago
Oops forgot to mention - a common issue in MP - when you first open MF with 
Films as start view, #selecteditem is not initiated so the Main title does not 
display until you press a key (only the first time you load MF - exit and 
reload is fine) 

Original comment by Dade...@gmail.com on 12 Aug 2012 at 5:04

GoogleCodeExporter commented 9 years ago
Re start view: yeas, I was also thinking about showing something "nicer" - we 
could add that to 6.1 maybe....
Re selecteditem: How can I reproduce that? afaik, MyFilms shows mastertitle in 
film list, no?

Original comment by Guzz...@googlemail.com on 12 Aug 2012 at 12:12

GoogleCodeExporter commented 9 years ago
MyFilms.xml uses #selecteditem not #myfilms.user.mastertitle.value. IIRC there 
is/was an issue with using #myfilms.user.mastertitle.value - maybe group names?
MyFilmsDetai.xml does use #myfilms.user.mastertitle.value.

So you should be able to reproduce the issue on any catalog when Films is 
selected as Start view using Default skin. I noticed in Black Glass skin files 
you only display #selecteditem when #myfilms.user.mastertitle.value is empty 
(so must be some case where it is!). 
However, other issues can occur when #selecteditem is not initialize on 
windowopen - though I have not seen any other issues in MF yet!

Original comment by Dade...@gmail.com on 12 Aug 2012 at 12:38

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2375.

Original comment by Mikeplan...@web.de on 12 Aug 2012 at 8:56

GoogleCodeExporter commented 9 years ago

Original comment by Dade...@gmail.com on 7 Sep 2012 at 12:50