search

drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Genre logos do not display correctly in MP 1.3.x + missing logos/genre images #169

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Using MP 1.3.0 alpha select 'Use logos of currently selected skin'
2. Open MP/MyFilms to Main Screen

What is the expected output? What do you see instead?
Some logos display, some do not. Some display the new Default skin logos style 
(text style), some display the 1.2.x Default skin logos

Please use labels and text to provide additional information.

IIRC my films searches skin\[skinname]media\logos folder first, then MyFIlms 
subfolder (installed by MF). So in some cases it finds genre logos for default 
skin, and in others it falls back to MyFilms subfolder. However as in the 
attached screenshot from ysmp, History displays both!

I think we should:
1. Remove the Blue3 logo set from installer (no longer used?)
2. Fix logos rules to accurate display Default 1.3.x skin logos wherever 
possible, if no logo exists, do NOT display the logos from My Films 1.2.x 
subfolder

Original issue reported on code.google.com by Dade...@gmail.com on 17 Aug 2012 at 3:47

Attachments:

GoogleCodeExporter commented 9 years ago 
To support TMDB and IMDB genre logos, the following genre logos should be 
suported in logo rules (and be available):
Action
Adventure
Animation
Biography
Comedy
Crime
Disaster
Documentary
Drama
Eastern
Family
Fantasy
Film Noir
Film-Noir
Foreign
Game-Show
History
Holiday
Horror
Indie
Music
Musical
Mystery
Neo-noir
News
Reality-TV
Road Movie
Romance
Science Fiction
Sci-Fi
Short
Sport
Sports Film
Suspense
Talk-Show
Thriller
War
Western

From those, the following are the same on IMDB and TMDB:
    Action
    Adventure
    Animation
    Comedy
    Crime
    Documentary
    Drama
    Family
    Fantasy
    History
    Horror
    Music
    Musical
    Mystery
    Romance
    Sport
    Thriller
    War
    Western

Original comment by Guzz...@googlemail.com on 18 Aug 2012 at 10:26

GoogleCodeExporter commented 9 years ago 
Based on the above lists: the following are missing from SVN 
nstaller\Skin.12\DefaultWide\Media\Logos\MyFilms:
Disaster
Eastern
Film Noir -exists in Installer\Thumbs\MyFilms\DefaultLogos
Film-Noir - can use same as above with diff logo rule
Foreign
Holiday
Indie
Neo-noir - maybe use Film Noir logo with diff logo rule?
News
Reality-TV - I have one already we never used.
Road Movie
Science Fiction - can use SciFi.png with different logo rule
Short
Sports Film - can use Sport.png with different logo rule
Suspense - maybe use Thriller logo with diff logo rule?
Talk-Show

Based on that we need 9-10 new logo images for both MF and Default logo packs - 
i.e. maye 20 new gfx

Original comment by Dade...@gmail.com on 18 Aug 2012 at 1:00

GoogleCodeExporter commented 9 years ago 
Of course, we can optimize the MyFilms logo rules to avoid multiple 
instnatiations of logos - I duped them more for generic reasons.
But it is mainly the question, IF we want to add new logos. If not, I would opt 
the logo rules for best results!

Original comment by Guzz...@googlemail.com on 18 Aug 2012 at 8:28

GoogleCodeExporter commented 9 years ago 
Have created the logos - and updated the MPlogoCreator to creator logos based 
on a template and a text file "Genre.txt" to create the stuff (in case we need 
it again)

Original comment by Guzz...@googlemail.com on 19 Aug 2012 at 3:12

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2399.

Original comment by Mikeplan...@web.de on 19 Aug 2012 at 3:14

GoogleCodeExporter commented 9 years ago 
I had created some of those previously, so I added them to MP 1.2.0 skin 
folder, using the same names as those you added for MP 1.3.x skin folder (just 
duplicated some images) - Not sure why you added Syfy as it was not in original 
list and is a channel logo not a genre logo, but I added it to 1.2.0 so they 
match>

The following genre logos are still missing for 1.2.0:
Disaster
Eastern
Foreign
Holiday
Indie
Nature
Religion
Road Movie
Short

Original comment by Dade...@gmail.com on 21 Aug 2012 at 9:29

GoogleCodeExporter commented 9 years ago 
Shouldn't the category view images also match the same values? I think in most 
cases they do, however the image names vary somewhat, and we have more category 
thumb images than logos.

Actually, Game-Show, Reality-TV, News, Talk-Show are only used for TV Series on 
IMDB. So I did not add genre thumbs for those.

So, in r2414 I added Genre Thumb images for Eastern, Holiday, Foreign, Suspense.
Duplicated Sci-Fi as Science Fiction, Film-noir as Film Noir and New-noir, 
Sport as Sports Films, Independent as Indie.

So I think we have genre thumbs for all TMDb genres except Road Movies and all 
IMDb genres except the TV Series ones.

Original comment by Dade...@gmail.com on 22 Aug 2012 at 4:36

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2467.

Original comment by Dade...@gmail.com on 30 Aug 2012 at 1:37

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2490.

Original comment by Dade...@gmail.com on 2 Sep 2012 at 6:47

GoogleCodeExporter commented 9 years ago 
Updated Logos Setup Wiki Docs to show different Logos for MP 1.2.x and MP 1.3

Original comment by Dade...@gmail.com on 7 Sep 2012 at 11:39

GoogleCodeExporter commented 9 years ago 
verified by ysmp's tests in 1.3 ;)

Original comment by Dade...@gmail.com on 18 Sep 2012 at 10:31