Add to Menu as Custom View via GUI does not save sort/layout options or display view image

[GoogleCodeExporter]

What steps will reproduce the problem?
1. In My Films GUI, select a field from Show all list - e.g. Disks
2. Change the layout and sort options
3. Add to Menu as Custom View

What is the expected output? What do you see instead?
1. You cannot select the new view until you reselect the db from Options menu, 
even reloading MF does not display it (reloading MP does)
2. No default image displays (MF should diplay default view image whenver no 
view image displays)
3. Layout and sort options are not saved
4. No View title - so you don't even know you are in a 'Disks' view.

See attached screenshot.

Please use labels and text to provide additional information.
Note: The above issues apply ONLY if you choose the same name as an existing 
View Field. If you select a different name, the only issue that applies is that 
no default image displays.

Perhaps most of the above could be prevented by a check to ensure no duplicate 
view names are possible?

The default image is an old issue:  MF should check in the following order for:
1. A View image selected in setup (Thumbs\MyFilms\DefaultImages folder)
2. Any view image (even Default.jpg) stored in 
Thumbs\MyFilms\ViewImages\subfolders
3. The default image selected  in Artwork Tab for views

Original issue reported on code.google.com by Dade...@gmail.com on 22 Aug 2012 at 11:28

[GoogleCodeExporter]

I should add, it is step 3 for default image that is not working, because when 
you add a view to Custom Menu in GUI 
1. it does not select a View image - you can only do that in Setup
2. normally there will not be a specific default image for most fields unless 
user adds them to Thumbs\MyFilms\ViewImages\subfolders
3. Default image selected in Artwork Tab is what should display in most cases, 
but doesn't.

Original comment by Dade...@gmail.com on 22 Aug 2012 at 11:31

[GoogleCodeExporter]

Forgot to attach screenshot :(

Original comment by Dade...@gmail.com on 22 Aug 2012 at 12:35

Attachments:

• MF6_DisksView.JPG

[GoogleCodeExporter]

Issues caused by recently added backnavigation cache - so "old" states were 
displayed regardless of changes done in GUI. Will clear the navigation cache on 
cahnges with menu - that should fix it. User will loose navigation hostory for 
that, but I think that is an acceptable solution.
Fixed in r2419

Original comment by Guzz...@googlemail.com on 23 Aug 2012 at 3:48

• Changed state: Fixed

[GoogleCodeExporter]

The issue re saving sort/layout seems to be resolved however, and it does 
display the default view image on the menu :)

BUT, it does NOT display the default view image when in a view that you Add to 
Custom menu. 

Same steps as above, - add a Languages View to Menu - open the view - no images.
See screenshot.

Original comment by Dade...@gmail.com on 24 Aug 2012 at 11:10

• Changed state: ReOpened

Attachments:

• AddCustomViewtoMenu.JPG

[GoogleCodeExporter]

This issue was closed by revision r2448.

Original comment by Mikeplan...@web.de on 27 Aug 2012 at 4:50

• Changed state: Fixed

[GoogleCodeExporter]

While this now works from GUI, a Default View image is no longer set when you 
create a new view in Setup - Custom Views Editor. IIRC it used to preset to 
MediaPortal\thumbs\MyFilms\DefaultImages\Views.jpg like it does now when you 
create a view in GUI.

Original comment by Dade...@gmail.com on 7 Sep 2012 at 12:23

• Changed state: ReOpened

[GoogleCodeExporter]

No, we didn't preset the image in setup - only the wizard did preselect it for 
the predefined views.
Actually, you do not NEED to define them - if you  don't MyFilms will try to 
display defaults at runtime - so this is optional (remember: You can place your 
own default images in views folders etc.). An explicit thumb definition in a 
view always overrides the search rules in GUI.
So if I would preset them to a default image, we would have to instruct/inform 
users, that they can remove it to let myfilms show default view thumbs based on 
folder rules.
That being said, do you still want me to preset to some of the default thumbs?

Original comment by Guzz...@googlemail.com on 9 Sep 2012 at 1:35

[GoogleCodeExporter]

Right! - however, if you create a view in setup and DO NOT select a default 
image, MF SHOULD display the default view image selected (and enabled) in 
Artwork setup - it does in Views Menu BUT NOT in the actual view (see 
screenshots)

To reproduce:
1. Create a new View in MF Setup Views Editor (e.g. Subtitles)
2. Make sure Default image for views is selected and enabled on Artwork tab (it 
is by default)
3. Open MF and Select the new view (e.g. Subtitles)
No image displays

IIRC this worked correctly before the latest changes.

Original comment by Dade...@gmail.com on 10 Sep 2012 at 4:42

Attachments:

• MFNewView.jpg

[GoogleCodeExporter]

Can confirm. The root cause is easy:
I check if there is a custom view definition for the image - and it is (not 
null) - it is set to "empty" - so works as dewsigned ;-)
Will add check for empty string.
Note: After that change, you can't override with custom view image to show NO 
image - as it will fallback to default - as requested.

Original comment by Guzz...@googlemail.com on 15 Sep 2012 at 11:29

[GoogleCodeExporter]

This issue was closed by revision r2525.

Original comment by Mikeplan...@web.de on 15 Sep 2012 at 11:33

• Changed state: Fixed

[GoogleCodeExporter]

"Note: After that change, you can't override with custom view image to show NO 
image - as it will fallback to default - as requested."

Yes, I think that is 'expected' because if you don't want to display the 
default image you can disable that in Artwork setup.

Original comment by Dade...@gmail.com on 16 Sep 2012 at 6:24

• Changed state: Verified